Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve config sync locking (support/2.12) #8511

Merged
merged 5 commits into from
Nov 27, 2020
Merged

Improve config sync locking (support/2.12) #8511

merged 5 commits into from
Nov 27, 2020

Commits on Nov 27, 2020

  1. Add Process::WaitForResult to allow waiting for the process to finish

    @julianbrost
    julianbrost committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    867a3c0 View commit details
    Browse the repository at this point in the history

  2. API filesync: wait for validation process to exit 

    This avoid having to pass a lock implictly using the captured variables
of a lambda.
    @julianbrost
    julianbrost committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    c5d8248 View commit details
    Browse the repository at this point in the history

  3. Use std::mutex instead of Spinlock

    @julianbrost
    julianbrost committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    07b9c62 View commit details
    Browse the repository at this point in the history

  4. ApiListener: merge new config validation and actication functions 

    Merge AsyncTryActivateZonesStage and TryActivateZonesStageCallback and
name the result TryActivateZonesStage. The old split was a leftover from
the one being a callback function with no actual meaningful separation.
    @julianbrost
    julianbrost committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    9dab864 View commit details
    Browse the repository at this point in the history

  5. Remove SpinLock 

    No longer needed as its only user now uses std::mutex.
    @julianbrost
    julianbrost committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    e7d9c51 View commit details
    Browse the repository at this point in the history