Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDCC/7715 Signed Urls for external tools #9001

Merged
merged 77 commits into from
Nov 30, 2022
Merged

GDCC/7715 Signed Urls for external tools #9001

merged 77 commits into from
Nov 30, 2022

Commits on Jul 29, 2021

  1. initial commit 

    impements POST-redirect-GET for DP Creator tool
POST is currently done on server, gets a redirect response, and GETs the new location in the browser
Need to change the way the base context is gotten for POST, as in the GET code, it always uses the extenal tool url as provided in the configuration - the redirect use be a different context than the configured tool url.
    @rtreacy
    rtreacy committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    07b34b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Merge branch 'develop' into 7715-signed-urls-for-external-tools

    @rtreacy
    rtreacy committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    c017fd3 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. rename getQueryParametersForUrl to handleRequest 

    remove some experimental code
    @rtreacy
    rtreacy committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    4c0fce0 View commit details
    Browse the repository at this point in the history

  2. rename getQueryParametersForUrl to handleRequest

    @rtreacy
    rtreacy committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    36fb985 View commit details
    Browse the repository at this point in the history

  3. add UrlSignerUtil.java

    @rtreacy
    rtreacy committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    b90216f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into 7715-signed-urls-for-external-tools

    @rtreacy
    rtreacy committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    fecd8a1 View commit details
    Browse the repository at this point in the history

  5. Merge branch '7715-signed-urls-for-external-tools' of github.com:IQSS… 

    …/dataverse into 7715-signed-urls-for-external-tools
    @rtreacy
    rtreacy committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    a7d1767 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Merge branch 'develop' into 7715-signed-urls-for-external-tools

    @rtreacy
    rtreacy committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    cb418a7 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. add signed Url to header and use POST for external tools, in particul… 

    …ar DPCreator

WIP - still need to handle use of signed Url to access resource on dataverse
    @rtreacy
    rtreacy committed May 2, 2022
    Configuration menu
    Copy the full SHA
    ac23437 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. use signedUrl for getting authenticated user. add allowedUrls field t… 

    …o ExtrenalTool
    @rtreacy
    rtreacy committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    7e82009 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. fix for validation method/comments

    @qqmyers
    qqmyers committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    7c9fa06 View commit details
    Browse the repository at this point in the history

  2. JSON API call to request signedUrl

    @qqmyers
    qqmyers committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    39180cc View commit details
    Browse the repository at this point in the history

  3. json read object/array from string methods from other branches

    @qqmyers
    qqmyers committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    55fafa5 View commit details
    Browse the repository at this point in the history

  4. Merge pull request IQSS#8788 from GlobalDataverseCommunityConsortium/… 

    …7715-signed-urls-for-external-tools

Validation fix and API call
    @rtreacy
    rtreacy committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    01973ff View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. define/use an additional secret key

    @qqmyers
    qqmyers committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    881e3db View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. refactor to allow URL token substitution outside tools framework

    @qqmyers
    qqmyers committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    208ab95 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Merge pull request IQSS#8802 from GlobalDataverseCommunityConsortium/… 

    …7715-signed-urls-for-external-tools

Define/use an additional secret key, Refactor token replacement for signed urls
    @rtreacy
    rtreacy committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    8c2f950 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. sending a list of allowed api calls to DPCreator

    @rtreacy
    rtreacy committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    0c22b18 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. tweak json read/write, getString, cleanup, logging

    @qqmyers
    qqmyers committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    1b31e6c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'IQSS/develop' into 7715-signed-urls-for… 

    …-external-tools
    @qqmyers
    qqmyers committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    2c90139 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. Merge pull request IQSS#8850 from GlobalDataverseCommunityConsortium/… 

    …7715-signed-urls-for-external-tools

7715 signed urls for external tools
    @rtreacy
    rtreacy committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    66355b0 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. add signer tests, flip param order so sign/validate match, fix val bug

    @qqmyers
    qqmyers committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    d4189f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. Merge pull request IQSS#8896 from GlobalDataverseCommunityConsortium/… 

    …7715-signed-urls-for-external-tools

Minor tweaks from IQSS#7325 review
    @rtreacy
    rtreacy committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    6331bec View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2022

  1. passes existing query params an signed urls in POST body as json

    Bob Treacy authored and Bob Treacy committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    22cdaaf View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. Merge remote-tracking branch 'IQSS/develop' into 

    7715-signed-urls-for-external-tools
    @qqmyers
    qqmyers committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    1039457 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. support signedURL in findUser

    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    4af2c05 View commit details
    Browse the repository at this point in the history

  2. update/fix requestSignedURL 

    - use the user if supplied
- require superuser
    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    0cd3e4a View commit details
    Browse the repository at this point in the history

  3. reduce duplication

    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    1095f96 View commit details
    Browse the repository at this point in the history

  4. cleanup, add hasToken call

    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    01fb249 View commit details
    Browse the repository at this point in the history

  5. remove ; in jvm option name

    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    12d98fa View commit details
    Browse the repository at this point in the history

  6. remove unnecessary 'apis' json object from manifest structure

    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    2287438 View commit details
    Browse the repository at this point in the history

  7. refactor, remove extra user variable

    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    1f82b19 View commit details
    Browse the repository at this point in the history

  8. cleanup, note :me works in UI

    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    a5ca4e2 View commit details
    Browse the repository at this point in the history

  9. add tool callback methods for dataset and datafile

    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    a413a13 View commit details
    Browse the repository at this point in the history

  10. add flyway script

    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    2ed2414 View commit details
    Browse the repository at this point in the history

  11. uses JsonObjectBuilder, elininating some string building that was messy 

    and brittle, Probably still a little string building could be cleaned up
    @rtreacy @qqmyers
    rtreacy authored and qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    6b9d69f View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'IQSS/develop' into 7715-signed-urls-for… 

    …-external-tools
    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    17eec51 View commit details
    Browse the repository at this point in the history

  13. use httpMethod in toolParams and allowedapicalls

    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    b098ba6 View commit details
    Browse the repository at this point in the history

  14. doc updates

    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    48b2e04 View commit details
    Browse the repository at this point in the history

  15. use java.util.Base64

    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    2eb90f1 View commit details
    Browse the repository at this point in the history

  16. release note

    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    86f910d View commit details
    Browse the repository at this point in the history

  17. Tests

    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    6a9ab48 View commit details
    Browse the repository at this point in the history

  18. remove test logging

    @qqmyers
    qqmyers committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    4da5be0 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. remove toolContext - wasn't set for dataset tools, isn't needed

    @qqmyers
    qqmyers committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    724f88d View commit details
    Browse the repository at this point in the history

  2. handle unsigned urls

    @qqmyers
    qqmyers committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    88bc73c View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Merge remote-tracking branch 'IQSS/develop' into 7715-signed-urls-for… 

    …-external-tools
    @qqmyers
    qqmyers committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    bcbc7e3 View commit details
    Browse the repository at this point in the history

  2. add sleepForReindex call

    @qqmyers
    qqmyers committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    63c175d View commit details
    Browse the repository at this point in the history

  3. and remove old sleep

    @qqmyers
    qqmyers committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    d3bc180 View commit details
    Browse the repository at this point in the history

  4. change sleep to be in seconds

    @qqmyers
    qqmyers committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    ceb3968 View commit details
    Browse the repository at this point in the history

  5. change other use of sleepForReindex

    @qqmyers
    qqmyers committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    8fb50a8 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Merge remote-tracking branch 'IQSS/develop' into 7715-signed-urls-for… 

    …-external-tools
    @qqmyers
    qqmyers committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    b3cd411 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Merge remote-tracking branch 'IQSS/develop' into 7715-signed-urls-for… 

    …-external-tools
    @qqmyers
    qqmyers committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    51b5dc2 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. fix typos

    @qqmyers
    qqmyers committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    022955d View commit details
    Browse the repository at this point in the history

  2. add SITE_URL for running single tests 

    FWIW: more recent Mockito has a mockStatic method but that doesn't appear to be available
    @qqmyers
    qqmyers committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    b357cb2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into 7715-signed-urls-for-external-tools IQSS#… 

    …7715
    @pdurbin
    pdurbin committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    559e5c5 View commit details
    Browse the repository at this point in the history

  4. rename sql script post 5.12.1 release IQSS#7715

    @pdurbin
    pdurbin committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    d59fbfc View commit details
    Browse the repository at this point in the history

  5. typos and minor wording and formatting fixes IQSS#7715

    @pdurbin
    pdurbin committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    de8386b View commit details
    Browse the repository at this point in the history

  6. use same term as in ext tools

    @qqmyers
    qqmyers committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    5c5468c View commit details
    Browse the repository at this point in the history

  7. doc for requestSignedUrl

    @qqmyers
    qqmyers committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    673987b View commit details
    Browse the repository at this point in the history

  8. Merge branch '7715-signed-urls-for-external-tools' of 

    https://github.com/GlobalDataverseCommunityConsortium/dataverse.git into
7715-signed-urls-for-external-tools
    @qqmyers
    qqmyers committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    7ffec36 View commit details
    Browse the repository at this point in the history

  9. Updates per reviews

    @qqmyers
    qqmyers committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    bf87542 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Changes per request.

    @qqmyers
    qqmyers committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    cda90ad View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'IQSS/develop' into 7715-signed-urls-for… 

    …-external-tools
    @qqmyers
    qqmyers committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    dbca546 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. feat: make API signing secret a JvmSetting IQSS#7715

    @poikilotherm
    poikilotherm committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    d1a5680 View commit details
    Browse the repository at this point in the history

  2. doc(signed-url): add configuration documentation IQSS#7715

    @poikilotherm
    poikilotherm committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    79f4c85 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Merge pull request #31 from poikilotherm/7715-jvmsetting 

    feat: make API signing secret a JvmSetting IQSS#7715
    @qqmyers
    qqmyers committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    70e350f View commit details
    Browse the repository at this point in the history

  2. wordsmithing

    @qqmyers
    qqmyers committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    5445a85 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. Merge remote-tracking branch 'IQSS/develop' into 7715-signed-urls-for… 

    …-external-tools
    @qqmyers
    qqmyers committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    fd55f20 View commit details
    Browse the repository at this point in the history

  2. update flyway numbering

    @qqmyers
    qqmyers committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    ffc5539 View commit details
    Browse the repository at this point in the history

  3. Merge branch '7715-signed-urls-for-external-tools' of https://github.… 

    …com/GlobalDataverseCommunityConsortium/dataverse.git into 7715-signed-urls-for-external-tools
    @qqmyers
    qqmyers committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    a5b748f View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Improved error handling per QA

    @qqmyers
    qqmyers committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    fbf7190 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Improve error handling

    @qqmyers
    qqmyers committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    398fd48 View commit details
    Browse the repository at this point in the history

  2. add content-type in requestSignedUrl

    @qqmyers
    qqmyers committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    77496b8 View commit details
    Browse the repository at this point in the history

  3. fix example json param

    @qqmyers
    qqmyers committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d7ecb3e View commit details
    Browse the repository at this point in the history

  4. unwrap wrapped response

    @qqmyers
    qqmyers committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    0c8216a View commit details
    Browse the repository at this point in the history

  5. fix for api key param

    @qqmyers
    qqmyers committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    590ee40 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Merge remote-tracking branch 'IQSS/develop' into 

    7715-signed-urls-for-external-tools
    @qqmyers
    qqmyers committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    32b9a8c View commit details
    Browse the repository at this point in the history