-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDL/7493 Batch Archiving #8610
Merged
kcondon
merged 28 commits into
IQSS:develop
from
TexasDigitalLibrary:TDL/7493-batch_archiving-only
Aug 8, 2022
Merged
TDL/7493 Batch Archiving #8610
Changes from 19 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
bf7b558
Merge and revert BagGenerator/Duracloud archiver changes in other PRs
qqmyers bc63cf8
Merge remote-tracking branch 'IQSS/develop' into
qqmyers b9d3fd1
Merge remote-tracking branch 'IQSS/develop' into TDL/7493-batch_archi…
qqmyers 9a90fe1
Merge remote-tracking branch 'IQSS/develop' into TDL/7493-batch_archi…
qqmyers 059bdfe
Merge remote-tracking branch 'IQSS/develop' into TDL/7493-batch_archi…
qqmyers 267297c
Merge remote-tracking branch 'IQSS/develop' into TDL/7493-batch_archi…
qqmyers 4c0d891
restore batch command
qqmyers 6ea4878
drop line removal
qqmyers 5f4d965
drop superuser req as this is admin and command already requires perm
qqmyers 2357dd2
add doc for batch archiving command
qqmyers e2bb433
clarify archival bag language
qqmyers df05c0e
Merge remote-tracking branch 'IQSS/develop' into TDL/7493-batch_archi…
qqmyers 5d3f6f5
Change to named query
qqmyers 5fe18a7
fix toDos re: createDataverseRequest()
qqmyers 86162de
remove call to set session user
qqmyers 408a51f
Merge remote-tracking branch 'IQSS/develop' into
qqmyers ccb8653
use class
qqmyers 4484c61
Merge remote-tracking branch 'IQSS/develop' into TDL/7493-batch_archi…
qqmyers 17baefc
Add comment per review
qqmyers 82d9e45
update/remove obsolete comments
qqmyers 45ad628
Merge remote-tracking branch 'IQSS/develop' into TDL/7493-batch_archi…
qqmyers abd3923
updates for archival status (missed/lost)
qqmyers 53dc116
typo
qqmyers e4a228d
Merge remote-tracking branch 'IQSS/develop' into TDL/7493-batch_archi…
qqmyers c918e64
Merge remote-tracking branch 'IQSS/develop' into TDL/7493-batch_archi…
qqmyers 2eed04b
don't archive harvested datasets
qqmyers bae7011
lower list-only logging to fine
qqmyers 4215ec5
doc /api response changes per QA
qqmyers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get how this works, but what's the reason to limit this way? (counting both successes and failures)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listonly=true gives you a list, so with limit working this way you can make sure that only the things you listed will get processed when you drop listonly=true.
Overall, the concern is about load, particularly if/when something is misconfigured and everything will fail after all the work to create a bag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these guaranteed to work with the list in the same order each time (i.e. if something added, it would be added at the end, so limit is guaranteed to get the things from the last listAll)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~yes - it's the new named query that is getting the list so unless something affects the return order from that (which I think will go in id order by default), it wouldn't change.