Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reworked controlled vocab language keys #10829

Merged
merged 10 commits into from
Sep 24, 2024

Conversation

stevenwinship
Copy link
Contributor

What this PR does / why we need it: Ever since we merged #10762 we've seen failures of the "Metadata Blocks Properties" check

Which issue(s) this PR closes:#10826

Closes #10826

Special notes for your reviewer:

Suggestions on how to test this: See new unit test

Does this PR introduce a user interface change? If mockups are available, please link/include them here: No

Is there a release notes update needed for this change?: No

Additional documentation: No

@stevenwinship stevenwinship self-assigned this Sep 9, 2024
@stevenwinship stevenwinship added FY25 Sprint 5 FY25 sprint 5 Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) labels Sep 9, 2024
@coveralls
Copy link

coveralls commented Sep 9, 2024

Coverage Status

coverage: 20.734% (-0.001%) from 20.735%
when pulling a877831 on 10826-fix-controlledvocab-after-merging-10762
into 4143031 on develop.

This comment has been minimized.

1 similar comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

2 similar comments

This comment has been minimized.

Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10826-fix-controlledvocab-after-merging-10762
ghcr.io/gdcc/configbaker:10826-fix-controlledvocab-after-merging-10762

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@stevenwinship stevenwinship removed their assignment Sep 10, 2024
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question.

scripts/api/data/metadatablocks/citation.tsv Show resolved Hide resolved
@pdurbin pdurbin self-assigned this Sep 17, 2024
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem fine to me, though I'm not an expert. The new unit tests are passing, as are the API tests. Approved.

@pdurbin pdurbin removed their assignment Sep 17, 2024
@pdurbin pdurbin removed the Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) label Sep 19, 2024
@pdurbin pdurbin added the Size: 3 A percentage of a sprint. 2.1 hours. label Sep 19, 2024
Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm not a fan of merging codes to avoid the Bundle issue, I don't have any alternatives and the solution here does fix the missing properties issue and, as has been noted, the merges affect only a few rare cases.

@landreev landreev self-assigned this Sep 23, 2024
@landreev landreev merged commit 212c64a into develop Sep 24, 2024
13 checks passed
@landreev landreev removed their assignment Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 5 FY25 sprint 5 Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: Done 🧹
5 participants