remove JAVA_IMAGE from Dockerfile (not working) #10722

IQSS · Jul 24, 2024 · f80ebce · f80ebce
1 parent e803c9c
commit f80ebce
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/modules/container-base/pom.xml b/modules/container-base/pom.xml
@@ -102,6 +102,7 @@
                                         </buildx>
                                         <dockerFile>Dockerfile</dockerFile>
                                         <args>
+                                            <!--Not clear if JAVA_IMAGE is working. See Dockerfile.-->
                                             <JAVA_IMAGE>${java.image}</JAVA_IMAGE>
                                             <UID>${base.image.uid}</UID>
                                             <GID>${base.image.gid}</GID>

diff --git a/modules/container-base/src/main/docker/Dockerfile b/modules/container-base/src/main/docker/Dockerfile
@@ -21,9 +21,10 @@
 #  - We provide some tweaks for development and monitoring
 #
 
-# Make the Java base image and version configurable (useful for trying newer Java versions and flavors)
-ARG JAVA_IMAGE="eclipse-temurin:17-jre-jammy"
-FROM $JAVA_IMAGE
+# There was a $JAVA_IMAGE variable here but it stopped working.
+# modules/container-base/pom.xml still has this but it might not
+# work anymore: <JAVA_IMAGE>${java.image}</JAVA_IMAGE>
+FROM eclipse-temurin:17-jre-jammy
 
 # Default payara ports to expose
 # 4848: admin console