fix: Prevent ImportCleaner from importing inherited static methods #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slarse
changed the title
slarse
changed the title
slarse
changed the title
slarse
changed the title
|
LGTM, thanks! |
monperrus
changed the title
|
Tested the snapshot on the previously problematic repair case, and it worked! I'll have a new PR for Verificatum on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3797
This PR prevents the ImportCleaner from importing static methods that are inherited from a parent class. Such imports cause compile errors if the static method is defined in a class in the default package. At best, they do absolutely nothing.