fix: Fix NPE due to duplicated package-info.java with setIgnoreDuplicateDeclarations(true) #3791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slarse
changed the title
slarse
changed the title
slarse
changed the title
|
LGTM, thanks @slarse |
monperrus
changed the title
|
thanks @slarse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3790
This PR fixes an NPE crash that occurs when the same project defines
package-info.javafiles for the same package but in different places, and one has setenv.setIgnoreDuplicateDeclarations(true). This appears quite a lot in the wild with multi-module projects.As per my musings in #3790, I don't think the JLS actually allows for duplication of
package-infofiles, and so I'm only allowing this when we are explicitly ignoring duplicated declarations.