Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: source position when there is a comment character in annotation #3720

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Fix: source position when there is a comment character in annotation #3720

merged 2 commits into from
Dec 15, 2020

Conversation

andrewbwogi
Copy link
Contributor

@andrewbwogi andrewbwogi commented Dec 4, 2020 •
edited
Loading

Closes #3606

@monperrus
Copy link
Collaborator

LGTM, unwip?

@monperrus
Copy link
Collaborator

@andrewbwogi unwip? ready to merge?

@andrewbwogi andrewbwogi changed the title WIP: fix source position when there is a comment character in annotation Fix: source position when there is a comment character in annotation Dec 9, 2020
@andrewbwogi
Copy link
Contributor Author

It's ok to merge

@monperrus monperrus merged commit 8f86cf9 into INRIA:master Dec 15, 2020
@monperrus
Copy link
Collaborator

Thanks a lot @andrewbwogi

@monperrus monperrus mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PositionBuilder modifier positions bug
2 participants
@andrewbwogi @monperrus