Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review fix: issue when using recursively defined annotation in shadow class #1711

Merged
merged 4 commits into from
Nov 13, 2017

Conversation

surli
Copy link
Collaborator

@surli surli commented Nov 10, 2017

Fix #1698

@surli surli changed the title WiP fix: issue when using recursively defined annotation in shadow class review fix: issue when using recursively defined annotation in shadow class Nov 10, 2017
@surli
Copy link
Collaborator Author

surli commented Nov 10, 2017

The fix here consists in checking that when visiting an annotation for shadow class creation, the parent call wasn't already the visit of an annotation of the same type.
It means that in the given AliasFor annotation (see the test), if you inspect the fields, they won't have any annotation on them even if in the file definition it uses AliasFor annotation.

So, it's not perfect but it was the easiest way to propose a fix in that kind of case.

@monperrus
Copy link
Collaborator

OK for me, thanks @surli . Will merge it on Monday if everybody agrees.

@monperrus monperrus merged commit 9f7679d into INRIA:master Nov 13, 2017
@monperrus
Copy link
Collaborator

thanks @surli!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants