review refactor: compute CtRole#forName without synonym #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK for me. |
|
It can be a problem for me, I used it but I don't remember where ... |
So, when you'll have a crash you'll know where you used it 😄 |
surli
changed the title
|
I think this is a good PR that simplifies maintenance |
msteinbeck
reviewed
Nov 10, 2017
| if (tokens.length == 1) { | ||
| return s; | ||
| } else { | ||
| StringBuffer buffer = new StringBuffer(tokens[0]); |
There was a problem hiding this comment.
I think you can use a StringBuilder here: https://stackoverflow.com/questions/355089/difference-between-stringbuilder-and-stringbuffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor is an alternative of #1603 it just get rid of synonyms and only consider given role names. As @monperrus said it's not backward compatible but it's not a huge problem especially if it's integrated in Spoon 6.0.0