test: add an architectural test to catch package creation during code review #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surli
reviewed
Nov 9, 2017
| @Test | ||
| public void testSpecPackage() throws Exception { | ||
| // contract: when a pull-request introduces a new package, it is made explicit during code review | ||
| // when a pull-request introduces a new package, this test fails and the author has to explicitly declare the new package here |
There was a problem hiding this comment.
It could be great to improve CONTRIBUTING.md with this kind of contract, WDYT?
There was a problem hiding this comment.
just do not make CONTRIBUTING.md too complex, so the new contributors does not have fear to contribute ;-)
There was a problem hiding this comment.
excellent point Pavel! I'll make a PR in that direction.
|
It could be great to improve CONTRIBUTING.md with this kind of
contract, WDYT?
Excellent idea!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.