Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: CtComment with \r separator #1679

Merged
merged 1 commit into from
Oct 31, 2017
Merged

test: CtComment with \r separator #1679

merged 1 commit into from
Oct 31, 2017

Conversation

surli
Copy link
Collaborator

@surli surli commented Oct 31, 2017

No description provided.

@surli surli mentioned this pull request Oct 31, 2017
Closed
@monperrus monperrus merged commit 9fbb9b7 into INRIA:master Oct 31, 2017
@monperrus
Copy link
Collaborator

thanks

@pvojtechovsky
Copy link
Collaborator

I afraid that this PR destroyed existing test testJavaDocCommentOnUnix which expects that JavaDocComment file contains unix EOL. I suggest to make new JavaDocCommentMac.java file with MAC EOL.

@surli
Copy link
Collaborator Author

surli commented Oct 31, 2017

I afraid that this PR destroyed existing test testJavaDocCommentOnUnix which expects that JavaDocComment file contains unix EOL

Actually I kept your own file and copy it in resources after changing the new line character. So I don't think so :)

@pvojtechovsky
Copy link
Collaborator

The ok, thanks for explanation ;-)

@surli surli mentioned this pull request Nov 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surli @monperrus @pvojtechovsky