Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(modifier): createCtModifierHandler that handles the modifiers #1677

Merged
merged 3 commits into from
Nov 6, 2017
Merged

refactor(modifier): createCtModifierHandler that handles the modifiers #1677

merged 3 commits into from
Nov 6, 2017

Conversation

tdurieux
Copy link
Collaborator

Goal: remove duplicate code

@monperrus
Copy link
Collaborator

looks good to me, this will probably be very useful for #1649

@tdurieux
Copy link
Collaborator Author

I would like to do the same with bodyholder, there are a lot of duplicate code to add/remove/ statements

@monperrus
Copy link
Collaborator

@surli if it's OK for you, don't hesitate to merge, so that we can proceed with #1649?

@surli surli merged commit 6961251 into INRIA:master Nov 6, 2017
@surli surli mentioned this pull request Nov 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdurieux @monperrus @surli