Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review chore: improve Travis configuration and speed-up builds #1655

Merged
merged 15 commits into from
Oct 31, 2017

Conversation

surli
Copy link
Collaborator

@surli surli commented Oct 26, 2017

Fix #1653

@INRIA INRIA deleted a comment from spoon-bot Oct 26, 2017
@INRIA INRIA deleted a comment from spoon-bot Oct 26, 2017
@INRIA INRIA deleted a comment from spoon-bot Oct 26, 2017
@INRIA INRIA deleted a comment from spoon-bot Oct 26, 2017
@INRIA INRIA deleted a comment from spoon-bot Oct 26, 2017
@surli surli changed the title Wip chore: improve Travis configuration review chore: improve Travis configuration Oct 26, 2017
@INRIA INRIA deleted a comment from spoon-bot Oct 26, 2017
@INRIA INRIA deleted a comment from spoon-bot Oct 26, 2017
@tdurieux
Copy link
Collaborator

I think you can simplify

  • mvn dependency:resolve
  • pip install --user CommonMark requests pygithub
  • sudo apt-get install xmlstarlet

@surli
Copy link
Collaborator Author

surli commented Oct 26, 2017

What do you mean by "simplify"?

@surli surli changed the title review chore: improve Travis configuration review chore: improve Travis configuration and speed-up builds Oct 26, 2017
@tdurieux
Copy link
Collaborator

tdurieux commented Oct 26, 2017

is useless: mvn dependency:resolve

is only required for the verify job
pip install --user CommonMark requests pygithub

is useful for something but I don't remember for what (website?):
sudo apt-get install xmlstarlet

@INRIA INRIA deleted a comment from spoon-bot Oct 26, 2017
@surli
Copy link
Collaborator Author

surli commented Oct 26, 2017

Thanks, I'll check that and try to improve the script.

@surli surli changed the title review chore: improve Travis configuration and speed-up builds WiP chore: improve Travis configuration and speed-up builds Oct 26, 2017
@INRIA INRIA deleted a comment from spoon-bot Oct 27, 2017
@surli surli changed the title WiP chore: improve Travis configuration and speed-up builds review chore: improve Travis configuration and speed-up builds Oct 27, 2017
@surli
Copy link
Collaborator Author

surli commented Oct 31, 2017

ping @monperrus ok for merging this one? It would speed up the builds

@monperrus
Copy link
Collaborator

It's a really good start. I would propose to split in two and refine:

Split in two:

  • the Travis job design
  • the test parallelization (here we may introduce flaky tests because many tests read and write to the same location, we have to make sure first that two tests never pretty-print / compile in the same target folder)

About the Travis job design, instead of a build Matrix, I would propose explicit names in Travis, and hence in the UI of travis (currently the job names are not super clear). The names would be:

  • JDK8
  • JDK9
  • CHECKSTYLE
  • SITE
  • etc

@tdurieux
Copy link
Collaborator

About the Travis job design, instead of a build Matrix, I would propose explicit names in Travis, and hence in the UI of travis (currently the job names are not super clear). The names would be:

I think it is not possible: travis-ci/travis-ci#5898

@monperrus
Copy link
Collaborator

monperrus commented Oct 31, 2017 via email

@tdurieux
Copy link
Collaborator

@surli
Copy link
Collaborator Author

surli commented Oct 31, 2017

@monperrus for me it's ready to merge

@monperrus monperrus merged commit eb73422 into INRIA:master Oct 31, 2017
@monperrus
Copy link
Collaborator

super maintainable! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants