review: fix: better tests for CtScanner

[pvojtechovsky]

This PR contains fixes of CtScanner, CtScanner test and Spoon model annotations related to CtScanner.

[pvojtechovsky]

@tdurieux @monperrus How to fix missing calls of scan(getComments()) in CtScanner? I guess it is correct to add them everywhere.
There is just question where?
A) as first scanned attribute
B) as last scanned attribute
C) on different position

Actually all 3 cases are there in CtScanner. Is it intentional? Should we unify it?

[monperrus]

I would say A).

[pvojtechovsky]

This property seems to be settable, because when I made it unset-able by

class CtIntersectionTypeReferenceImpl ... { ...
	public <C extends CtActualTypeContainer> C setActualTypeArguments(List<? extends CtTypeReference<?>> actualTypeArguments) {
		return (C) this;
	}

Then TypeReferenceTest#testRecursiveTypeReference started to fail.
But I am not able to decide yet what is correct. Test or Unsettable property. I do not understand spoon/java model around CtIntersectionTypeReference.

So check this one carefully.

[pvojtechovsky]

I suggest to add calls of scan(getComments()) in next PR. This one is big enough.

[monperrus]

In general I'm fine with the idea of this PR.

However, it's really big for good code review.

Since it contains the changes of #1627 do we concentrate on #1627 first? or can we remove the moetamodel from this one and merge this one independently?

[pvojtechovsky]

#1627 Meta model cannot be removed, because the test of new CtScanner is based on this new metamodel.

I agree to focus on meta model first. And I am open to spent on that discussion some days, because I found metamodel of spoon as quite interesting feature for future maintenance and generation of spoon code - so it should be well designed, with respect to your meta model knowledge of spoon too!

[pvojtechovsky]

So now metamodel is merged and this one is next in the review queue ;-)

[pvojtechovsky]

I extracted PR #1668 to simplify this one. So lets merge #1668 first

[pvojtechovsky]

Now this PR contains only fix of CtScannerTest and fixes of spoon model, which were found by that fixed test.

[monperrus]

just reviewed the test and added some documentation.

really good work, thanks!

I'm OK to merge, are you done?

[pvojtechovsky]

yes I am done. Please merge it soon. I will then rebase other PRs so I can clean my workspace and continue with next features ;-)