Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: Fix new bug related with "--lines" argument #1558

Merged
merged 2 commits into from
Sep 23, 2017

Conversation

surli
Copy link
Collaborator

@surli surli commented Sep 22, 2017

No description provided.

@surli
Copy link
Collaborator Author

surli commented Sep 22, 2017

@pvojtechovsky could you have a look on this one? It's related to the DefaultJavaPrettyPrinter on the usage of env.isPreserveLineNumbers: I'm not quite sure how to solve it for now and I think it might be related with your current PRs.

@pvojtechovsky
Copy link
Collaborator

The problem was caused by missing source position on CtFieldReferenceImpl/simpleName=='f'.
I have no idea why it worked (or if it worked) before.

I am finished. The solution is ready for merge.

@surli surli changed the title WiP: Fix new bug related with "--lines" argument review: Fix new bug related with "--lines" argument Sep 23, 2017
@surli
Copy link
Collaborator Author

surli commented Sep 23, 2017

Great! Thank you @pvojtechovsky 👍

@surli surli merged commit 9d03327 into INRIA:master Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants