refactor: Move ElementPrinterHelper

[pvojtechovsky]

• ElementPrinterHelper moved next to DJPP - it belongs there some like others.
• ListPrinter made package protected too

[pvojtechovsky]

@monperrus WDYT?

[monperrus]

indeed, thanks.

the fact that it is not tested directly clearly shows that it was never part of the public API.

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-20170921.175952-35

New API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-SNAPSHOT

Detected changes: 3.

Change 1

Name	Element
Old	class spoon.reflect.visitor.ListPrinter
New	class spoon.reflect.visitor.ListPrinter
Code	java.class.nonPublicPartOfAPI
Description	Class 'spoon.reflect.visitor.ListPrinter' is indirectly included in the API (by the means of method return type for example) but the class is not accessible (neither public nor protected).
Breaking	binary: non_breaking,

Change 1

Name	Element
Old	class spoon.reflect.visitor.ListPrinter
New	class spoon.reflect.visitor.ListPrinter
Code	java.class.visibilityReduced
Description	Visibility was reduced from 'public' to 'package'.
Breaking	binary: breaking

Change 2

Name	Element
Old	class spoon.reflect.visitor.printer.ElementPrinterHelper
New	none
Code	java.class.removed
Description	Class was removed.
Breaking	binary: breaking

Change 3

Name	Element
Old	method spoon.reflect.visitor.printer.ElementPrinterHelper spoon.reflect.visitor.DefaultJavaPrettyPrinter::getElementPrinterHelper()
New	method spoon.reflect.visitor.ElementPrinterHelper spoon.reflect.visitor.DefaultJavaPrettyPrinter::getElementPrinterHelper()
Code	java.method.returnTypeChanged
Description	The return type changed from 'spoon.reflect.visitor.printer.ElementPrinterHelper' to 'spoon.reflect.visitor.ElementPrinterHelper'.
Breaking	binary: breaking