Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review CatchVariableReferenceFunction, CatchVariableScopeFunction #1145

Merged
merged 4 commits into from
Jan 30, 2017

Conversation

pvojtechovsky
Copy link
Collaborator

This PR contains CatchVariableReferenceFunction, CatchVariableScopeFunction.
The main purpose is CatchVariableReferenceFunction, which returns all the references to the catch variable. The second on is helper classes which might be useful for others so it is public.

It depends on PR CtQuery#filterChildren(null) #1140

The tests will be added later, because they share a lot with tests of #1136

@pvojtechovsky pvojtechovsky changed the title WIP CatchVariableReferenceFunction, CatchVariableScopeFunction review CatchVariableReferenceFunction, CatchVariableScopeFunction Jan 25, 2017
@surli
Copy link
Collaborator

surli commented Jan 30, 2017

The tests will be added later, because they share a lot with tests of #1136

It seems you already have your tests, in the similar way than #1136. Do you want to add more tests or is it only conflict solving?

@pvojtechovsky
Copy link
Collaborator Author

I do not need more tests for this PR. It was conflict solving.

@surli surli merged commit 21616a4 into INRIA:master Jan 30, 2017
@pvojtechovsky pvojtechovsky deleted the CatchVariableReferenceFunction branch January 30, 2017 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants