feature: CtPackageReference should have a getQualifiedName in addition to getSimpleName

[surli]

No description provided.

[surli]

Looking on this feature request: shouldn't we put getQualifiedName directly in CtReference ?

[surli]

I answer myself: it's a bad idea. We got a lot of different references for which it makes no sense to have a FQN.

[monperrus]

I agree with you, it's a bad idea :-)

…

On 10/25/17 3:57 PM, Simon Urli wrote: I answer myself: it's a bad idea. We got a lot of different references for which it makes no sense to have a FQN. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1330 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAxDUhqB1egOav4F5pVzkvE7sv9jTJgRks5svz41gaJpZM4NpXLg>.

[surli]

In fact CtPackageReference already reference the FQN of package in its simpleName, see:

spoon/src/main/java/spoon/reflect/factory/PackageFactory.java

Line 52 in bf1233a

return createReference(pack.getQualifiedName());

So, should we align its behaviour on the class behaviour: simpleName with only the last package simple name, and a FQN computed from it.
Or it does not make any sense to use simpleName in CtPackageReference, and we should only document the fact the FQN is always returned and close this issue?

[monperrus]

If this line is always used and we are sure that simple name is always the fully qualified name, then 1) we document 2) we still add the new method for improving the API, that would simply delegate to getSimpleName

…

On 10/26/17 10:38 AM, Simon Urli wrote: In fact CtPackageReference already reference the FQN of package in its simpleName, see: https://github.com/INRIA/spoon/blob/bf1233aa362c1d23030c0d491e8de15eacf12276/src/main/java/spoon/reflect/factory/PackageFactory.java#L52 So, should we align its behaviour on the class behaviour: simpleName with only the last package simple name, and a FQN computed from it. Or it does not make any sense to use simpleName in CtPackageReference, and we should only document the fact the FQN is always returned and close this issue? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1330 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAxDUmyn3t09dMVt0kP787x7_lejSZnaks5swETtgaJpZM4NpXLg>.

[surli]

If this line is always used

Yes, a PackageReference is always created using a FQN name, either from the CtPackage FQN or from a reflect Package FQN.

1. we document 2) we still add the new method for improving the API, that would simply delegate to getSimpleName

I'll change the PR and test in that way then.