Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'encoding' attribute to fields in LG schema #284

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

james-strauss-uwa
Copy link
Collaborator

Deleted old branch (eagle-1231), reproduced this work in new branch (eagle-1231-2).

Adds the 'encoding' attribute to fields in the JSON schema for logical graphs. Possible values of the attribute are:

  • "binary"
  • "pickle"
  • "dill" (default)
  • "npy"
  • "base64"
  • "utf-8"

Copy link
Contributor

sourcery-ai bot commented Sep 13, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @james-strauss-uwa - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@coveralls
Copy link

Coverage Status

coverage: 79.684% (-0.01%) from 79.694%
when pulling 8a537a9 on eagle-1231-2
into ea6cc06 on master.

Copy link
Collaborator

@myxie myxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @james-strauss-uwa.

@myxie myxie merged commit 8c0a39f into master Sep 20, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants