Apply temp. patch to Triton code to resolve conflicting cache dirs in TP case #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TP case. Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
joerunde
added a commit
that referenced
this pull request
Jun 3, 2024
…ch instead. (#35) I tested the previous fix for the Triton cache collision issue (see: #34) and it didn't work. I now see errors like: ``` FileNotFoundError: [Errno 2] No such file or directory: '/home/vllm/.triton/cache/1feb415f3280ca46eea8c4407a58c23e/fused_moe_kernel.json.tmp.pid_72_c0a0033e-6147-4520-ae3a-3847d02598f8' ``` which now shows the `uuid` instead of a random integer, but problem remains. This PR implements a different workaround, proposed by @cyang49, that tells Triton to use a custom cache manager which assigns a different directory based on the process id. This time I have tested it and it seems to work. --------- Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com> Signed-off-by: Nick Hill <nickhill@us.ibm.com> Signed-off-by: Joe Runde <joe@joerun.de> Co-authored-by: Chih-Chieh-Yang <chih.chieh.yang@ibm.com> Co-authored-by: Joe Runde <joseph.runde@ibm.com> Co-authored-by: Nick Hill <nickhill@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing Mixtral pods with TP>1 failing with errors like:
It seems like there is some conflict in the Triton cache directories when using multi-processing. This has actually been fixed upstream in Triton, but the fix hasn't made it into Triton v2.3.0 which is what vLLM is currently using.
This change essentially applies same fix that has made it into Triton main branch inside our container.