added SASLVersion in config #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
I think it makes sense. @bai what do you think, also do we have anyone else who can have a look? |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sarama force SASL V1 handshake when Kafka protocol is greater than 1.0.
Azure Eventhub is still using SASLV0.
I moved the SASL protocol version to the config, defaulting to V0 (like before), but I also removed the auto V1 when Kafka > 1.0
Refer to #1408 for more info.
@varun06 Let me know if this is what you expected or let me know what you prefer, like keeping the old behaviour but adding a config flag to disable the force change to V1 when Kafka > 1.0