Skip to content

Commit

Permalink
fix(shebang): avoid node arguments (#21)
Browse files Browse the repository at this point in the history
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Co-authored-by: Tomas Pilar <tomas.pilar@ibm.com>
  • Loading branch information
pilartomas and Tomas Pilar committed Aug 22, 2023
1 parent d3bd7ba commit eb67bde
Show file tree
Hide file tree
Showing 5 changed files with 37 additions and 21 deletions.
33 changes: 16 additions & 17 deletions .eslintrc.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
env:
node: true
es2022: true
extends:
- "eslint:recommended"
- "plugin:import/recommended"
- "prettier"
plugins:
- import
parserOptions:
ecmaVersion: "latest"
sourceType: "module"
ignorePatterns: ["src/utils/version.js"]
rules:
"import/order":
- error
- newlines-between: always
env:
node: true
es2022: true
extends:
- "eslint:recommended"
- "plugin:import/recommended"
- "prettier"
plugins:
- import
parserOptions:
ecmaVersion: "latest"
sourceType: "module"
rules:
"import/order":
- error
- newlines-between: always
18 changes: 17 additions & 1 deletion .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ jobs:
strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
- uses: actions/checkout@v3
Expand All @@ -24,3 +23,20 @@ jobs:
cache: "yarn"
- run: yarn --frozen-lockfile
- run: yarn lint
healthcheck:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [16.x, 18.x, 20.x]

steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
cache: "yarn"
- run: yarn --frozen-lockfile
- run: npm install -g .
- run: genai --version
2 changes: 1 addition & 1 deletion src/cli.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env node --no-warnings
#!/usr/bin/env node

import { parser } from "./parser.js";
import { isUsageError } from "./errors.js";
Expand Down
1 change: 0 additions & 1 deletion src/middleware/client.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { Client } from "@ibm-generative-ai/node-sdk";

// eslint-disable-next-line import/namespace
import { version } from "../utils/version.js";

export const clientMiddleware = (args) => {
Expand Down
4 changes: 3 additions & 1 deletion src/utils/version.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import pkg from "../../package.json" assert { type: "json" };
import { readFile } from 'node:fs/promises';

const pkg = JSON.parse(await readFile(new URL('../../package.json', import.meta.url)));

export const version = pkg.version;

0 comments on commit eb67bde

Please sign in to comment.