implementing missing pyproject on transforms #327
Conversation
| .transforms.run-src-file | ||
| # set the version of python transform that this depends on. | ||
| set-versions: | ||
| $(MAKE) TRANSFORM_PYTHON_VERSION=${CODE2PARQUET_PYTHON_VERSION} TOML_VERSION=$(CODE2PARQUET_PYTHON_VERSION) .transforms.set-versions |
There was a problem hiding this comment.
indeed, TOML_VERSION=$(DOCKER_IMAGE_VERSION)
There was a problem hiding this comment.
I don't believe TOML_VERSION is needed. Can you try removing it?
data-processing-lib/python/src/data_processing/test_support/abstract_test.py
Show resolved
Hide resolved
| COPY requirements.txt requirements.txt | ||
| RUN pip install --no-cache-dir -r requirements.txt | ||
| # Install ray project source | ||
| COPY --chown=ray:users src/ src/ |
There was a problem hiding this comment.
can it be done in the Makefile by .defaults.copy-lib ?
There was a problem hiding this comment.
Its done there, but we still need to install
There was a problem hiding this comment.
yes we need to install it, but we don't have to copy each part separately, the temp directory contains only relevant files
There was a problem hiding this comment.
wait, we are installing local directory. We do not need any makefiles support here
There was a problem hiding this comment.
Makefile infrastructure is not part of the docker build environment. yes, we could copy in the local Makefile, but it references things outside of this directory.
| [project] | ||
| name = "dpk_docid_transform_ray" | ||
| version = "0.4.0.dev6" | ||
| requires-python = ">=3.10" |
There was a problem hiding this comment.
Technically yes, but we are doing this way everywhere else
There was a problem hiding this comment.
Is this a transitive dependency from data-prep-toolkit and if so, can it be removed?
Why are these changes needed?
Related issue number (if any).