Initial version of profiler #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daw3rd
requested changes
Jun 13, 2024
transforms/universal/aggregator/ray/src/aggregator_transform_ray.py
Outdated
Show resolved
Hide resolved
transforms/universal/aggregator/ray/src/aggregator_transform_ray.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Maybe there should be 2 test files so aggregation is done across multiple calls to transform()
There was a problem hiding this comment.
1 is good enough
|
@daw3rd one of the larger issues I am getting with this is testing. Because I am:
|
Maybe promoting the methods added in spark (highlighted below) to the super class and using them somehow in the super class would do it. Then for this transform, you override _validate_metadata() or use some other mechanism to get any metadata file. Similar override of the unhighlighted method could be done for the csv file? 
|
daw3rd
requested changes
Jun 13, 2024
transforms/universal/aggregator/ray/src/aggregator_transform_ray.py
Outdated
Show resolved
Hide resolved
done |
daw3rd
requested changes
Jun 17, 2024
data-processing-lib/python/src/data_processing/test_support/abstract_test.py
Outdated
Show resolved
Hide resolved
daw3rd
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
New transform
Related issue number (if any).
https://github.ibm.com/ai-models-data/data-prep-kit-inner/issues/84