Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming, docs and fix for recent binary file processing changes #153

Merged
merged 3 commits into from
May 21, 2024

Conversation

daw3rd
Copy link
Member

@daw3rd daw3rd commented May 20, 2024

Why are these changes needed?

Documentation, normalization and a fix to noop that did not use byte_array as a parameter.

Related issue number (if any).

Signed-off-by: David Wood <dawood@us.ibm.com>
Signed-off-by: David Wood <dawood@us.ibm.com>
@daw3rd daw3rd requested a review from blublinsky May 20, 2024 19:57
Copy link
Collaborator

@blublinsky blublinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to add anything

@daw3rd daw3rd merged commit b490449 into binary May 21, 2024
11 checks passed
@daw3rd daw3rd deleted the binary-david branch June 24, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants