Button Colour Fixed

[anishaswain]

Addresses #972 #359

Changes proposed in this pull request:

• background of edit button is changed to #3e95ff and colour changed to #fff ($white)
• new class "btn-extra" added for button "bar-code","checkout".
• btn-extra class in active state has background colour #799fd2 and colour $white and on hover background colour changes to #4a7ec3.
• btn-primary class is added in appropriate places to give similar looks to all the "add" and "update" buttons

appointment-list before:

appointment-list after:

custom-form page before:

custorn-form page after:

report-generate page before:

report-generate page after:

inventory-list page before:

inventory-list page after:

patient-list page before:

patient-list page after:

@jkleinsc @jglovier @tangollama

[jkleinsc]

@anisha1234 looks good to me.

@jglovier can you look at this and give your feedback?

[anishaswain]

@jglovier @jkleinsc Do I need to do some changes over here ?

[jglovier]

@jkleinsc @anisha1234 sorry for the delay. I'll review as soon as possible, but will need a day or two to get back to this due to current workload. ❤️

[jglovier]

@anisha1234 again my apologies for taking so long to respond here. 🙈

Overall I think this is a good step forward, but there's still a few things we need to address before I'm comfortable with merging this in.

1. Let's keep the button colors to just three variants:

• green for affirmative actions
• red for destructive actions
• gray for neutral actions

I'd prefer not to introduce that new blue. It doesn't fit with the app color palette, and it's unclear why it is a different color. Using too many different button colors is confusing for users.

There should be a limited set of colors that have obvious connotations to the type of action they perform.

2. The discharge/checkout buttons should be the same width so that there is no staggering in the vertical alignment of buttons in each button column.

Other than that, I think the contrast is much better. 🎉

I've been planning to move away from the button style in those rows and style them just as text links because the buttons – especially when several patient item rows appear on a single view – become the dominant visual element, which isn't idea.

But for now, I think this is a solid step forward. Thanks again for your work on this!

[tangollama]

@anisha1234 any progress?

[anishaswain]

@tangollama I have been busy with some school stuff, with semester exams approaching next week... I was unable to devote adequate time to the project currently. But I will create a pull request in next two days resolving this issue..

[anishaswain]

@jglovier @tangollama @jkleinsc as mentioned I have made changes to keep the button colors to just three variants and I have also set the discharge/checkout button to same width.
Yes, as for buttons being a dominant visual element on addition of multiple rows , I agree with that . And my suggestion on this topic would be addition of meaningful icons as they aren't that distracting and serve the purpose at the same time.

[tangollama]

@jglovier I believe your requested changes have been satisfied. I think we should merge this into master. Any objections?

cc: @jkleinsc

[jglovier]

@anisha1234 thanks again for all of your effort on this one!! ⚡ ❤️ ⚡