This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
[CLEANUP] eslint object-curly-spacing
#770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
amyrlam
added a commit
to amyrlam/hospitalrun-frontend
that referenced
this pull request
Nov 16, 2016
Re: http://eslint.org/docs/rules/object-curly-spacing Realized my fork was out of date when started looking at this issue recently. I have previously used ember-suave, just getting started with eslint. Since many of the rules outlined in HospitalRun#732 aren’t part of eslint recommended https://github.com/DockYard/eslint-plugin-ember-suave/blob/master/config/recommended.js, I suggest adding the rules to the eslintrc.js so that they are enforced as they are fixed. If this PR is ok: - I’ll add the rest of the already completed rules from HospitalRun#732 in a follow-on PR. - I will go through the remaining rules from HospitalRun#732, and add the rule to the .eslintrc.js as the rules are fixed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{'foo': 'bar'}->{ 'foo': 'bar' }Part of #732.
cc @HospitalRun/core-maintainers