This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Issue 661: Use 'Sex Not Entered' for patients with missing gender on … #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
reviewed
Sep 23, 2016
| var sexGrouping = patientBySex[visit.get('patient.sex')]; | ||
| var sex = visit.get('patient.sex'); | ||
| if (!sex) { | ||
| sex = 'Sex Not Entered'; |
There was a problem hiding this comment.
@akong Can you localize the text here? You can put the label under patient.labels.sexNotEntered in the localization file at app/locales/en/translations.js and then you can pull it in to the controller by calling
this.get('i18n').t('patients.labels.sexNotEntered'),There was a problem hiding this comment.
Got it! Will update the PR later today.
There was a problem hiding this comment.
@jkleinsc Updated the pull request with the suggested changes.
|
@jkleinsc any idea why greenkeeper is not reporting a status? I'm inclined to merge the change, but I don't want to break our established process. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #661 .
Changes proposed in this pull request:
cc @HospitalRun/core-maintainers