Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Create new number component #116

Closed
1 task
jkleinsc opened this issue Jun 18, 2015 · 8 comments
Closed
1 task

Create new number component #116

jkleinsc opened this issue Jun 18, 2015 · 8 comments
Labels
🚀enhancement an issue/pull request that adds a feature to the application help wanted indicates that an issue is open for contributions ux

Comments

@jkleinsc
Copy link
Member

jkleinsc commented Jun 18, 2015

Right now our number validation allows for numbering like 123,456 but codewise we are expecting numbers without commas. We should create a component that will let people enter a number with commas but will save the value without commas.

Either that or we need to change how validation works to eliminate commas but that is not as friendly

TODO

  • Create number component
@jkleinsc jkleinsc added 🚀enhancement an issue/pull request that adds a feature to the application ux labels Jun 18, 2015
@tangollama tangollama added the help wanted indicates that an issue is open for contributions label Aug 4, 2015
@tangollama tangollama added this to the HospitalRun 1.0 milestone Oct 14, 2015
@jkleinsc jkleinsc removed the help wanted indicates that an issue is open for contributions label Nov 10, 2015
@jkleinsc
Copy link
Member Author

@zinyando is looking into this one.

@tangollama
Copy link
Member

Question to @zinyando, where did you get with this?

cc: @jkleinsc

@zinyando
Copy link
Contributor

@tangollama I got a little busy but I will take another stab at it tomorrow. Will post the link to the PR when its ready in a day or 2 cc @jkleinsc

@tangollama
Copy link
Member

Great. Thank you.

Typed or dictated imperfectly on my iPhone (717.385.9970)

On Nov 30, 2015, at 3:55 PM, Lennex Zinyando notifications@github.com wrote:

@tangollama I got a little busy but I will take another stab at it tomorrow. Will post the link to the PR when its ready in a day or 2 cc @jkleinsc


Reply to this email directly or view it on GitHub.

@zinyando
Copy link
Contributor

@jkleinsc is this issue still valid? Validation seems to not accept commas in numbers anymore.

@jkleinsc
Copy link
Member Author

@zinyando you are correct in that validation doesn't allow commas. For usability purpose, I still think we should create a component that will let people enter a number with commas but will save the value without commas.

@tangollama tangollama added the help wanted indicates that an issue is open for contributions label Mar 15, 2016
@tompaana
Copy link

tompaana commented Jun 8, 2016

Note that depending on the localization a comma can be considered a decimal point.

@tangollama
Copy link
Member

@zinyando are you thinking about working this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀enhancement an issue/pull request that adds a feature to the application help wanted indicates that an issue is open for contributions ux
Projects
None yet
Development

No branches or pull requests

5 participants