Skip to content

Commit

Permalink
cmd/geth: rename --vmodule to --log.vmodule (ethereum#27071)
Browse files Browse the repository at this point in the history
renames `--vmodule` to `--log.vmodule`, and prints a warning if the old form is used.
  • Loading branch information
ajsutton authored and devopsbo3 committed Nov 10, 2023
1 parent 758e98b commit 518de7f
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion internal/debug/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,17 @@ var (
Value: 3,
Category: flags.LoggingCategory,
}
logVmoduleFlag = &cli.StringFlag{
Name: "log.vmodule",
Usage: "Per-module verbosity: comma-separated list of <pattern>=<level> (e.g. eth/*=5,p2p=4)",
Value: "",
Category: flags.LoggingCategory,
}
vmoduleFlag = &cli.StringFlag{
Name: "vmodule",
Usage: "Per-module verbosity: comma-separated list of <pattern>=<level> (e.g. eth/*=5,p2p=4)",
Value: "",
Hidden: true,
Category: flags.LoggingCategory,
}
logjsonFlag = &cli.BoolFlag{
Expand Down Expand Up @@ -149,6 +156,7 @@ var (
// Flags holds all command-line flags required for debugging.
var Flags = []cli.Flag{
verbosityFlag,
logVmoduleFlag,
vmoduleFlag,
backtraceAtFlag,
debugFlag,
Expand Down Expand Up @@ -252,7 +260,14 @@ func Setup(ctx *cli.Context) error {
// logging
verbosity := ctx.Int(verbosityFlag.Name)
glogger.Verbosity(log.Lvl(verbosity))
vmodule := ctx.String(vmoduleFlag.Name)
vmodule := ctx.String(logVmoduleFlag.Name)
if vmodule == "" {
// Retain backwards compatibility with `--vmodule` flag if `--log.vmodule` not set
vmodule = ctx.String(vmoduleFlag.Name)
if vmodule != "" {
defer log.Warn("The flag '--vmodule' is deprecated, please use '--log.vmodule' instead")
}
}
glogger.Vmodule(vmodule)

debug := ctx.Bool(debugFlag.Name)
Expand Down

0 comments on commit 518de7f

Please sign in to comment.