Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryfs: Fix HEAD installation #32588

Merged
merged 3 commits into from
Oct 3, 2018
Merged

cryfs: Fix HEAD installation #32588

merged 3 commits into from
Oct 3, 2018

Conversation

smessmer
Copy link
Contributor

@smessmer smessmer commented Oct 1, 2018

  • It needs the libomp dependency and corresponding build flags

  • It needs a non-shallow git clone to compute version number correctly

  • Have you followed the guidelines for contributing?

  • Have you checked that there aren't other open pull requests for the same formula update/change?

  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?

  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?


- It needs the libomp dependency and corresponding build flags
- It needs a non-shallow git clone to compute version number correctly
@fxcoudert
Copy link
Member

Head cannot be built without OpenMP?

@smessmer
Copy link
Contributor Author

smessmer commented Oct 2, 2018

It can be built without OpenMP by passing in -DDISABLE_OPENMP=on, but that would result in a much slower mount time for CryFS file systems (well, on multi core systems at least).

@smessmer
Copy link
Contributor Author

smessmer commented Oct 2, 2018

Why does CI fail for this? I didn't find a helpful error message on Jenkins, just

failed: brew doctor

@fxcoudert
Copy link
Member

C: 34: 24: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@fxcoudert fxcoudert merged commit 9ba3d6e into Homebrew:master Oct 3, 2018
@fxcoudert
Copy link
Member

Thanks @smessmer

@smessmer smessmer deleted the fix_cryfs branch October 3, 2018 17:12
@lock lock bot added the outdated PR was locked due to age label Nov 2, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants