Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to build kubectl with cgo #28187

Closed

Conversation

bks7
Copy link

@bks7 bks7 commented May 23, 2018

Modify formula to support build dynamic binary with CGO_ENABLED=1.
Building kubectl without cgo breaks dns name resolution since it
uses /etc/resolv.conf for getting resolvers while nothing in macos
should use it for name resolution.
More information about this issue can be obtained here -
kubernetes/release#469

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Modify formula to support build dynamic binary with CGO_ENABLED=1.
Building kubectl without cgo breaks dns name resolution since it
uses /etc/resolv.conf for getting resolvers while nothing in macos
should use it for name resolution.
More information about this issue can be obtained here -
kubernetes/release#469
@ilovezfs
Copy link
Contributor

Thanks for the PR, @bks7. This is something you'll need to get sorted out with upstream, though, as we don't want to add a temporary option in the formula just to work around an issue CC @cblecker

@ilovezfs ilovezfs closed this May 23, 2018
@bitglue
Copy link

bitglue commented May 23, 2018

@ilovezfs Upstream says it needs to get sorted out downstream. kubernetes/release#469 (comment)

kubernetes/release is designed to run in a docker container within a Kubernetes cluster, and since installing Xcode in such an environment isn't possible, it disables cgo. I don't see a reason for Brew to be limited by those constraints. It would be nice if at least one of the documented install methods had working DNS. Will you reconsider?

@lock lock bot added the outdated PR was locked due to age label Jun 22, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants