v2ray: depend on go@1.20 #144400
Merged
v2ray: depend on go@1.20 #144400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`v2ray` 5.7.0 fails to build using Go 1.21 (the current version in the `go` formula) because the version of `quic-go` in use didn't support 1.21. `quic-go` now supports Go 1.21 but `v2ray` hasn't created a new release yet, so this has to temporarily use `go@1.20` if we want to build it in the interim time.
github-actions
bot
added
the
go
3 tasks
chenrui333
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?v2ray5.7.0 fails to build using Go 1.21 (the current version in thegoformula) because the version ofquic-goin use didn't support 1.21.quic-gonow supports Go 1.21 butv2rayhasn't created a new release yet (see v2fly/v2ray-core#2644), so this has to temporarily usego@1.20if we want to build it in the interim time.I've left a note in the formula to mention that we should try to switch back to
depends_on "go" => :buildwhen there is a newv2rayversion. If we would rather simply wait for a newv2rayversion (accepting that we can't bottle this for Sonoma until then), I'll close this accordingly.Failure when bottling for Sonoma: #142161 (comment)