Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walk: rename from llama #139110

Merged
merged 2 commits into from
Aug 17, 2023
Merged

walk: rename from llama #139110

merged 2 commits into from
Aug 17, 2023

Conversation

antonmedv
Copy link
Contributor

@antonmedv antonmedv commented Aug 9, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Aug 9, 2023
Formula/walk.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 changed the title walk 1.0.0 (new formula) walk 1.4.0 (new formula) Aug 9, 2023
@chenrui333
Copy link
Member

@antonmedv 👋 thanks for the PR, can you update the commit msg as walk 1.4.0 (new formula)

@antonmedv
Copy link
Contributor Author

Sure, done.

@antonmedv
Copy link
Contributor Author

I don’t understand why go build is failing in tests.

Formula/walk.rb Outdated Show resolved Hide resolved
@chenrui333
Copy link
Member

chenrui333 commented Aug 10, 2023

actually it should be rename other than new formula

@chenrui333 chenrui333 changed the title walk 1.4.0 (new formula) walk: rename from llama Aug 10, 2023
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Aug 10, 2023
@chenrui333
Copy link
Member

failed with commit style 😱

@antonmedv
Copy link
Contributor Author

https://docs.brew.sh/Rename-A-Formula:

  • Updated commit message.
  • Added formula_renames.json
  • Deleted llama.rb

@antonmedv
Copy link
Contributor Author

Can’t understand why build is failing

@chenrui333 chenrui333 mentioned this pull request Aug 13, 2023
6 tasks
@chenrui333
Copy link
Member

Can’t understand why build is failing

I will check in a bit (now we have sorted go 1.21.0)

@chenrui333 chenrui333 added the help wanted Task(s) needing PRs from the community or maintainers label Aug 13, 2023
@branchvincent branchvincent removed help wanted Task(s) needing PRs from the community or maintainers automerge-skip `brew pr-automerge` will skip this pull request labels Aug 17, 2023
Copy link
Member

@branchvincent branchvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needed a depends_on "go", thanks!

@branchvincent branchvincent added the ready to merge PR can be merged once CI is green label Aug 17, 2023
@chenrui333 chenrui333 removed the new formula PR adds a new formula to Homebrew/homebrew-core label Aug 17, 2023
@github-actions
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 17, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 17, 2023
Merged via the queue into Homebrew:master with commit a6eec76 Aug 17, 2023
12 checks passed
@antonmedv antonmedv deleted the walk branch August 17, 2023 17:16
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants