Issue86 functional theme change button #115
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ANSH127 RESOLVE CONFLICTS |
|
@HimanshuNarware Done |
|
@ANSH127 light theme has lots of problems like the font are not visible clearly. also internship section need improvement |
|
|
@HimanshuNarware let me fix the font issue and tell me in light theme what changes you want. in internship page? |
|
could I make the card bg light black? |
|
I fixed the font issue and changed the bg color of the card CareerZunction.-.Google.Chrome.2024-05-14.19-29-03.mp4 |
|
@ANSH127 footer section text is not visible |
This comment was marked as duplicate.
This comment was marked as duplicate.
…ub.com/ANSH127/CareerZunction_Intern into Issue86-Functional-theme-change-button
|
done CareerZunction.-.Google.Chrome.2024-05-14.22-36-44.mp4 |
CareerZunction.-.Google.Chrome.2024-05-15.22-50-45.mp4 |
|
Can you make hover effect in light theme to dark purple not black @ANSH127 ? You have changed theme at internship section to black, it was dark purple can you revert that , and check whether it is applied to other sections also for dark mode |
|
@PSS2134 okay sure |
…ub.com/ANSH127/CareerZunction_Intern into Issue86-Functional-theme-change-button
|
@PSS2134 done CareerZunction.-.Google.Chrome.2024-05-16.11-17-06.mp4 |
|
In the Internship section, for light theme, the cards look too bright at borders, also the footer is not distinguishable , may be you can add a light grey line or something and keep the default theme to dark, when someone opens the site @ANSH127 |
|
@PSS2134 I have set the border gray on the light theme , distinguished the footer, and set by default the dark theme CareerZunction.-.Google.Chrome.2024-05-19.14-55-47.-.Trim.mp4 |
|
Still looks bright and can't see gray line at the footer can you check @ANSH127 , Also resolve conflicts after changes |
|
@ANSH127 are you still working on this issue. |
|
@ANSH127 for the light theme use a black background on the card, but for the dark it is the same |
@ANSH127 only for the light theme , dark theme remain same |
|
@ANSH127 Do one thing again raise PR with recommended changes |
add a feature to toggle the theme
CareerZunction.-.Google.Chrome.2024-05-13.16-15-35.mp4