Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more options for DiscordRPC #4014

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Noro95
Copy link

@Noro95 Noro95 commented Sep 15, 2024

added more custom options & settings to the discordrpc
user can now customize

  • app name (Playing xxx), by providing a custom discord app id instead of HGL's, falls back to HGL's if none provided
  • activity title and state, now removable (empty string) and if undefined falls back to old ones
    and added title & state variables, {game} for game name & {platform} for platform/os name

hope i didn't miss/error in something, and always up for suggestions.

p.s. didn't do anything for images as they're already customizable enough :D
altho i do recommend making the small icon an image link instead of relying on discord's app assets, that is in case you think HGL would need more visibility with custom apps


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

flavioislima commented Sep 15, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Noro95
Copy link
Author

Noro95 commented Sep 15, 2024

I have read the CLA Document and I hereby sign the CLA

@Noro95
Copy link
Author

Noro95 commented Sep 15, 2024

also a heads up, CLA link in CONTRIBUTING.md is invalid

@flavioislima
Copy link
Member

also a heads up, CLA link in CONTRIBUTING.md is invalid

ok, will check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants