Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add before parameter to the nc history API #331

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

pedroferreira1
Copy link
Member

Acceptance Criteria

  • Add before parameter to the nc history API

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

Copy link
Member

@r4mmer r4mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion(non-blocking): Add tests for nc apis.

I know this repo does not have coverage enabled but we should add these new apis.
Maybe we should do this on another PR, waht do you think?

@pedroferreira1 pedroferreira1 merged commit 4af2317 into dev Aug 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants