Update for xcb 1.1 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I had a quick look and tested your changes, everything seems to be working fine. With one exception: The example now crashes once I close one of the windows. It looks like it got a little more complicated to gracefully exit. Do you think it's worth waiting for upstream? Otherwise, I am okay with doing a release with said wart. |
|
I'd suggest holding for now: I'm not sure it's working 100% in wezterm and I'd like to get to the bottom of it! |
The API changed quite substantially (and for the better!). This commit is adjusting for that. There's a wart that I hope will be tackled upstream in rust-x-bindings/rust-xcb#188
wez
added a commit
to wez/wezterm
that referenced
this pull request
May 8, 2022
|
I think this is good to review/merge now! |
|
Thanks, it's looking fine to me except for the fact that rust-xcb has no release with your required fix yet and thus this PR still points to your fork. |
|
Merging for now, I will do a release once there is a new rust-xcb release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API changed quite substantially (and for the better!).
This commit is adjusting for that.
There's a wart that I hope will be tackled upstream in
rust-x-bindings/rust-xcb#188