Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test[dace]: Fix skip rules for dace optional dependency #1637

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Sep 10, 2024

This PR fixes the solution to skip testcases dependent on dace provided in #1635. The problem was that pytest.skip function was called within __init__ and/or conftest files in the test folder.

Additional changes:

  • Moved all dace-related tests in dace_tests package folder.
  • Introduced pytest marker requires_dace at package level, which needs to be included in all test files.
  • Run ruff on test code in dace_tests package to cleanup and sort the import list.

@edopao
Copy link
Contributor Author

edopao commented Sep 10, 2024

@philip-paul-mueller Tested with Spack-build.

Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edopao edopao merged commit 03f100c into GridTools:main Sep 11, 2024
31 checks passed
@edopao edopao deleted the dace-skip_rules branch September 11, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants