Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[next][dace]: generic scalar expressions as fieldop args #1633

Merged
merged 12 commits into from
Sep 19, 2024

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Sep 6, 2024

This PR adds support for symbolic expressions as field-operator arguments. This is needed to support expressions like (0 - 4) which is used in GTIR to represent the negative value -4.

@edopao edopao requested a review from havogt September 6, 2024 16:47
@edopao
Copy link
Contributor Author

edopao commented Sep 16, 2024

I will update this PR with support for generic scalar arguments.

@edopao edopao closed this Sep 16, 2024
@edopao edopao reopened this Sep 16, 2024
@edopao edopao changed the title feat[next][dace]: generic symbolic expressions as fieldop args feat[next][dace]: generic scalar expressions as fieldop args Sep 16, 2024
@edopao edopao removed the request for review from havogt September 18, 2024 15:48
Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no big changes, just some small suggestions and some questions. I think we can merge after that round.

As requested I skipped the changes in type_synthesizer.

Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
There is one point with the comment.

@edopao edopao merged commit acefd84 into GridTools:main Sep 19, 2024
31 checks passed
@edopao edopao deleted the dace-gtir-negative_literal_args branch September 19, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants