feat[next]: GT4Py programs as DaCe SDFGConvertibles #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edopao
reviewed
Apr 12, 2024
tests/next_tests/integration_tests/multi_feature_tests/ffront_tests/test_laplacian.py
Outdated
Show resolved
Hide resolved
tests/next_tests/integration_tests/multi_feature_tests/ffront_tests/test_laplacian.py
Outdated
Show resolved
Hide resolved
tests/next_tests/integration_tests/multi_feature_tests/ffront_tests/test_laplacian.py
Outdated
Show resolved
Hide resolved
|
Just a general comment, I am wondering if DaCe offers alternatively the option to register the conversion functions, instead of having to make them part of the object. (E.g. like jax pytrees work) If only the current option is available I am wondering if we should go with a monkey patching approach to remove the dace import from unrelated modules. But this is for @egparedes to answer. (And we could think of the other option as a contribution to productice DaCe.) |
egparedes
requested changes
Jul 22, 2024
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py
Outdated
Show resolved
Hide resolved
DropD
reviewed
Jul 23, 2024
egparedes
reviewed
Jul 24, 2024
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py
Outdated
Show resolved
Hide resolved
tests/next_tests/integration_tests/feature_tests/dace/test_orchestration.py
Outdated
Show resolved
Hide resolved
egparedes
approved these changes
Jul 25, 2024
edopao
reviewed
Jul 26, 2024
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_sdfg.py
Outdated
Show resolved
Hide resolved
|
cscs-ci run |
|
cscs-ci run default |
|
cscs-ci run |
|
cscs-ci run default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fieature, a GT4Py.next Program can be placed inside a DaCe.program region, where its SDFG is automatically extracted and placed as a nested SDFG. This allows fusing multiple stencils under one SDFG -compilation unit-.
This feature is needed for implementing DaCe orchestration, e.g. in ICON4Py.