Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[next]: DaCe scalar argument in stencil closure #1293

Merged
merged 6 commits into from
Jul 24, 2023

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Jul 21, 2023

Description

Add support for argument of stencil closure with ScalarType. Baseline only supported FieldType arguments.

Requirements

  • All fixes and/or new features come with corresponding tests.
  • Important design decisions have been documented in the approriate ADR inside the docs/development/ADRs/ folder.

If this PR contains code authored by new contributors please make sure:

  • All the authors are covered by a valid contributor assignment agreement provided to ETH Zurich and signed by the employer if needed.
  • The PR contains an updated version of the AUTHORS.md file adding the names of all the new contributors.

@edopao edopao requested review from petiaccja and gronerl July 21, 2023 13:25
@edopao edopao marked this pull request as ready for review July 21, 2023 14:05
Copy link
Contributor

@petiaccja petiaccja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is pretty straightforward, we've already discussed the only questionable part, so it's approved.

@edopao edopao merged commit db31c4f into GridTools:main Jul 24, 2023
18 checks passed
@edopao edopao deleted the dace-scalar_arg_fix branch July 24, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants