feature[next] enable field origin in GTFN backend #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
requested changes
Jun 30, 2023
havogt
reviewed
Jul 4, 2023
| from gt4py.next.iterator import transforms | ||
|
|
||
| if lift_mode != transforms.LiftMode.FORCE_INLINE: | ||
| pytest.xfail("origin not yet supported in gtfn") |
There was a problem hiding this comment.
Can you fix the message? Do you understand what's not working?
There was a problem hiding this comment.
I don't really know, it crashes when freeing the temporaries, either bad logic or memory corruption. Probably also unrelated to this PR because it works when everything is inlined and the inputs and outputs are the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the origin of
LocatedFields through the bindings to GridTools.