Fix lambda inliner if parameter is not referenced #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
reviewed
Mar 9, 2023
| @pytest.mark.parametrize("opcount_preserving", [True, False]) | ||
| @pytest.mark.parametrize("name,testee,expected", test_data) | ||
| def test(name, opcount_preserving, testee, expected): | ||
| if isinstance(expected, dict): |
There was a problem hiding this comment.
I don't like that some tests are executed twice, but I don't see a nice way to improve on that. We could skip in the else branch, but it wouldn't be very readable, too...
There was a problem hiding this comment.
While the result might be the same the test still tests different code paths opcount_preserving so they are not really executed twice.
havogt
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small bug in the lambda inliner such that parameters which are not referenced are correctly eliminated, i.e. now
transforms to
Additionally tests for the inliner were introduced (didn't exist before).