Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI docs #1170

Merged
merged 20 commits into from
Feb 24, 2023
Merged

Update CI docs #1170

merged 20 commits into from
Feb 24, 2023

Conversation

DropD
Copy link
Contributor

@DropD DropD commented Feb 16, 2023 •
edited
Loading

Description

Update CI docs and remove old CIGR files.

Moved to be based on a rebased branch to keep the commit history more readable.

Requirements

Before submitting this PR, please make sure:

  • You have run the code checks, tests and documentation build successfully
  • All fixes and all new functionality are tested and documentation is up to date
  • You looked at the review checklist

Additionally, if this PR contains code authored by new contributors:

  • All the authors are covered by a valid contributor assignment agreement,
    signed by the employer if needed, provided to ETH Zurich
  • The names of all the new contributors have been added to an updated
    version of the AUTHORS.rst file included in the PR

@DropD DropD requested a review from egparedes February 16, 2023 15:33
egparedes
egparedes reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions but it looks good overall.

docs/development/CI/cscs-ci.md Outdated Show resolved Hide resolved
docs/development/CI/cscs-ci.md Outdated Show resolved Hide resolved
docs/development/CI/cscs-ci.md Outdated Show resolved Hide resolved
docs/development/CI/cscs-ci.md Outdated Show resolved Hide resolved
docs/development/CI/infrastructure.md Outdated Show resolved Hide resolved
docs/development/CI/infrastructure.md Outdated Show resolved Hide resolved
docs/development/CI/infrastructure.md Show resolved Hide resolved
docs/development/CI/cscs-ci.md Show resolved Hide resolved
@DropD DropD requested a review from egparedes February 24, 2023 08:54
egparedes
egparedes reviewed Feb 24, 2023
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Just keep one of the versions of the diagram (preferably the mermaid one 😆 ) and we're ready to go.

docs/development/CI/infrastructure.md Outdated Show resolved Hide resolved
@DropD DropD requested a review from egparedes February 24, 2023 10:00
egparedes
egparedes approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@egparedes egparedes changed the title Update Ci docs Update CI docs Feb 24, 2023
@egparedes
Copy link
Contributor

cscs-ci run

@DropD DropD merged commit 96f661a into GridTools:main Feb 24, 2023
@DropD DropD deleted the ci-docs branch February 24, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egparedes egparedes egparedes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DropD @egparedes