Version 0.2.1 #27
Merged
Version 0.2.1 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in the sqlalchemy integrations that caused the custom column types to raise when used on nullable columns. This was caused by the custom column types not checking for `None` in the `process_bind_param` and `process_result_value` functions, which is a silly noob mistake, but it's something that I completely overlooked when I first added the column types. This is fixed now, and I have added a couple of simple regression test cases for it as well.
The `run_doctests.py` script was manually collecting the `linearmoney.ext` module, but the extensions module is collected as part of the root `linearmoney` module by pdoc, so this was redundant and was causing a warning to be printed when running the `docs:test-in-source` environment script. This is fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug in sqlalchemy integrations on nullable columns. See individual commit messages for details.