Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PACKAGING! #41

Merged
merged 9 commits into from
Aug 8, 2022
Merged

PACKAGING! #41

merged 9 commits into from
Aug 8, 2022

Conversation

itsthejoker
Copy link
Member

Description:

It's the packaging PR.

⚠️ This DRASTICALLY CHANGES how Bubbles should be run on the server. Not a hard fix, but does need to be updated before it's deployed.

Also changes how a plugin is defined and called. Plugins can now be loaded arbitrarily and are not all loaded automatically at runtime. There was a slightly large refactor required to make that happen, but I think the overall result is (mostly) cleaner.

Checklist:

  • Code Quality
  • Pep-8
  • Tests (if applicable)
  • Success Criteria Met
  • Inline Documentation
  • Wiki Documentation (if applicable)

@itsthejoker itsthejoker requested a review from a team as a code owner August 6, 2022 05:00
Copy link
Contributor

@TimJentzsch TimJentzsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me.
I left a few minor comments for improvements/questions though.

Makefile Show resolved Hide resolved
bubbles/commands/help.py Show resolved Hide resolved
bubbles/config.py Outdated Show resolved Hide resolved
bubbles/main.py Outdated Show resolved Hide resolved
bubbles/main.py Outdated Show resolved Hide resolved
update.py Outdated Show resolved Hide resolved
@itsthejoker itsthejoker merged commit 716752f into master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants