[SOLVED] ModuleNotFoundError: No module named 'basicsr' #136

f-rank · 2023-12-14T23:15:41Z

First, confirm

I have read the instruction carefully
I have searched the existing issues
I have updated the extension to the latest version

What happened?

updated all through comfyui manager and on restart it started throwing in console and node didn't load anymore.

Steps to reproduce the problem

this is pre-workflow

Sysinfo

windows 10, firefox, 3070, other nodes installed:

0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_IPAdapter_plus
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ResizeAspectratio.py
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\kohya_hiresfix.py
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\efficiency-nodes-comfyui
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUi-NoodleWebcam
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\canvas_tab
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\style_aligned_comfy
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_ImageProcessing
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Video-Matting
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfy-plasma
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Inspire-Pack
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\cg-use-everywhere
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\SD-Latent-Interposer
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUi_NNLatentUpscale
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfy-consistency-vae
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\masquerade-nodes-comfyui
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-tooling-nodes
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\cg-image-picker
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_Cutoff
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\As_ComfyUI_CustomNodes
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyLiterals
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_experiments
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\cg_custom_core
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_Dave_CustomNode
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfy_PoP
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_FizzNodes
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Advanced-ControlNet
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Custom-Scripts
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_UltimateSDUpscale
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Frame-Interpolation
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\Derfuu_ComfyUI_ModdedNodes
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_essentials
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\rgthree-comfy
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-KJNodes
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_Comfyroll_CustomNodes
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\facerestore_cf
0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyI2I
0.1 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-prompt-reader-node
0.1 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_segment_anything
0.1 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\NodeGPT
0.2 seconds (IMPORT FAILED): D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-reactor-node
0.2 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-N-Nodes
0.2 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Impact-Pack
0.5 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager
0.7 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_tinyterraNodes
0.7 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\SeargeSDXL
0.9 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-LaMA-Preprocessor
0.9 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-mixlab-nodes
1.2 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-art-venture
1.7 seconds (IMPORT FAILED): D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Allor
1.9 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui
2.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-0246
5.2 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ClipInterrogate.py
6.2 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_Custom_Nodes_AlekPet

Relevant console log

D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable>run_nvidia_gpu.bat

D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable>.\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build
** ComfyUI startup time: 2023-12-14 23:05:17.436918
** Platform: Windows
** Python version: 3.11.6 (tags/v3.11.6:8b6ee5b, Oct  2 2023, 14:57:12) [MSC v.1935 64 bit (AMD64)]
** Python executable: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\python_embeded\python.exe
** Log path: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\comfyui.log

Prestartup times for custom nodes:
   0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\rgthree-comfy
   0.0 seconds: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager

Total VRAM 8192 MB, total RAM 32620 MB
xformers version: 0.0.22.post7
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3070 Laptop GPU : cudaMallocAsync
VAE dtype: torch.bfloat16
Using xformers cross attention
Adding extra search path checkpoints E:/SD/models
Adding extra search path configs D:\WORK\conda_envs\automatic\stable-diffusion-webui\models/Stable-diffusion
Adding extra search path vae D:\WORK\conda_envs\automatic\stable-diffusion-webui\models/VAE
Adding extra search path loras D:\WORK\conda_envs\automatic\stable-diffusion-webui\models/Lora
Adding extra search path upscale_models D:\WORK\conda_envs\automatic\stable-diffusion-webui\models/ESRGAN
Adding extra search path upscale_models D:\WORK\conda_envs\automatic\stable-diffusion-webui\models/SwinIR
Adding extra search path embeddings D:\WORK\conda_envs\automatic\stable-diffusion-webui\embeddings
Adding extra search path hypernetworks D:\WORK\conda_envs\automatic\stable-diffusion-webui\models/hypernetworks
Adding extra search path controlnet D:\WORK\conda_envs\automatic\stable-diffusion-webui\extensions\sd-webui-controlnet\models
2023-12-14 23:05:21.357012: I tensorflow/core/util/port.cc:113] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`.
WARNING:tensorflow:From D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\python_embeded\Lib\site-packages\keras\src\losses.py:2976: The name tf.losses.sparse_softmax_cross_entropy is deprecated. Please use tf.compat.v1.losses.sparse_softmax_cross_entropy instead.

Web extensions folder found at D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\web\extensions\ComfyLiterals
WAS Node Suite: OpenCV Python FFMPEG support is enabled
WAS Node Suite: `ffmpeg_bin_path` is set to: C:\Apps\ffmpeg\ffmpeg-5.1-full_build-shared\bin\
WAS Node Suite: Finished. Loaded 197 nodes successfully.

        "Everything you've ever wanted is on the other side of fear." - George Addair

### Loading: ComfyUI-Inspire-Pack (V0.51)
[ComfyUI-0️⃣ 2️⃣ 4️⃣ 6️⃣ ] Loaded all nodes and apis (/0246-parse).
[Allor]: New updates are available.
Traceback (most recent call last):
  File "D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1800, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Allor\__init__.py", line 7, in <module>
    loader.check_updates()
  File "D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Allor\Loader.py", line 240, in check_updates
    repo.git.reset('--hard', 'origin/' + branch_name)
  File "D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\python_embeded\Lib\site-packages\git\cmd.py", line 736, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\python_embeded\Lib\site-packages\git\cmd.py", line 1316, in _call_process
    return self.execute(call, **exec_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\python_embeded\Lib\site-packages\git\cmd.py", line 1111, in execute
    raise GitCommandError(redacted_command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git reset --hard origin/main
  stderr: 'Downloading resources/logo.png (1.9 MB)
Error downloading object: resources/logo.png (dafc878): Smudge error: Error downloading resources/logo.png (dafc8789058e0a6c1341785a72195c746278283a455525c69cbf13153807a914): batch response: This repository is over its data quota. Account responsible for LFS bandwidth should purchase more data packs to restore access.

Errors logged to 'D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Allor\.git\lfs\logs\20231214T230529.4203263.log'.
Use `git lfs logs last` to view the log.
error: external filter 'git-lfs filter-process' failed
fatal: resources/logo.png: smudge filter lfs failed'

Cannot import D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Allor module for custom nodes: Cmd('git') failed due to: exit code(128)
  cmdline: git reset --hard origin/main
  stderr: 'Downloading resources/logo.png (1.9 MB)
Error downloading object: resources/logo.png (dafc878): Smudge error: Error downloading resources/logo.png (dafc8789058e0a6c1341785a72195c746278283a455525c69cbf13153807a914): batch response: This repository is over its data quota. Account responsible for LFS bandwidth should purchase more data packs to restore access.

Errors logged to 'D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Allor\.git\lfs\logs\20231214T230529.4203263.log'.
Use `git lfs logs last` to view the log.
error: external filter 'git-lfs filter-process' failed
fatal: resources/logo.png: smudge filter lfs failed'
Adding D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes to sys.path
Efficiency Nodes: Attempting to add Control Net options to the 'HiRes-Fix Script' Node (comfyui_controlnet_aux add-on)...Success!
Efficiency Nodes: Attempting to add 'AnimatedDiff Script' Node (ComfyUI-AnimateDiff-Evolved add-on)...Success!
Loaded efficiency nodes from D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\efficiency-nodes-comfyui
Loaded ControlNetPreprocessors nodes from D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux
Loaded AdvancedControlNet nodes from D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Advanced-ControlNet\control/control.py
Could not find AnimateDiff nodes
Loaded IPAdapter nodes from D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_IPAdapter_plus
Loaded VideoHelperSuite from D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite
### Loading: ComfyUI-Impact-Pack (V4.46.2)
### Loading: ComfyUI-Impact-Pack (Subpack: V0.3.2)
### Loading: ComfyUI-Inspire-Pack (V0.51)
[Impact Pack] Wildcards loading done.
### Loading: ComfyUI-Manager (V1.13.6)
### ComfyUI Revision: 1820 [329c5719] | Released on '2023-12-14'
FETCH DATA from: https://github.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json
FETCH DATA from: https://github.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json
FETCH DATA from: https://github.com/ltdrdata/ComfyUI-Manager/main/model-list.json
FETCH DATA from: https://github.com/ltdrdata/ComfyUI-Manager/main/alter-list.json
[ComfyUI-Manager] default cache updated: https://github.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json
[ComfyUI-Manager] default cache updated: https://github.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json
[ComfyUI-Manager] default cache updated: https://github.com/ltdrdata/ComfyUI-Manager/main/model-list.json
[ComfyUI-Manager] default cache updated: https://github.com/ltdrdata/ComfyUI-Manager/main/alter-list.json
Error processing font C:\Users\Utilizador\AppData\Local\Microsoft\Windows\Fonts\AcuminVariableConcept.otf: In FT2Font: Can not load face (SFNT font table missing; error code 0x8e)
--------------
Mixlab Nodes: Loaded
--------------
packaging is already installed.
cpuinfo is already installed.
git is already installed.
moviepy is already installed.
cv2 is already installed.
skbuild is already installed.
typing is already installed.
diskcache is already installed.
llama_cpp is already installed.

[SD Prompt Reader] Node version: 1.2.0
[SD Prompt Reader] Core version: 1.3.4.post1
Failed to auto update `Quality of Life Suit`
QualityOfLifeSuit_Omar92_DIR: D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92
Total VRAM 8192 MB, total RAM 32620 MB
xformers version: 0.0.22.post7
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3070 Laptop GPU : cudaMallocAsync
VAE dtype: torch.bfloat16
Torch version: 2.1.0+cu121
Traceback (most recent call last):
  File "D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1800, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-reactor-node\__init__.py", line 25, in <module>
    from .nodes import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
  File "D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-reactor-node\nodes.py", line 19, in <module>
    from basicsr.utils.registry import ARCH_REGISTRY
ModuleNotFoundError: No module named 'basicsr'

Cannot import D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-reactor-node module for custom nodes: No module named 'basicsr'

Additional information

the allor nodes error in the console is related to some lfs file stipulation and seems unrelated to this.

wutao369 · 2023-12-15T02:17:18Z

I also encountered the same problem after upgrading:

File "D:\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1800, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-reactor-node_init.py", line 25, in
from .nodes import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-reactor-node\nodes.py", line 19, in
from basicsr.utils.registry import ARCH_REGISTRY
ModuleNotFoundError: No module named 'basicsr'

Gourieff · 2023-12-15T05:24:14Z

Yes, ComfyUI doesn't have "basicsr" lib by default - but without this lib CodeFormer doesn't have all its functionality
To install this package you should run install.bat (inside ReActor's folder) or do it manually from ComfyUI root:

  python_embeded\python.exe -m pip install basicsr

Issue #136

Gourieff · 2023-12-15T05:41:14Z

"What's New" section of the Instruction has been updated
Actual only for ComfyUI Portable users
With A1111's ComfyUI everything works ok without these steps

ql0wn4 · 2023-12-15T06:33:59Z

Hi, I tried what you say but both ways (running install.bat or doing it manually) does not work.

This is the error it gives:

Collecting future (from basicsr)
Using cached future-0.18.3.tar.gz (840 kB)
Preparing metadata (setup.py) ... error
error: subprocess-exited-with-error

× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [6 lines of output]
Traceback (most recent call last):
File "", line 2, in
File "", line 34, in
File "C:\Users\Username\AppData\Local\Temp\pip-install-vp3ysw6c\future_27c89a6b79154a9a8ce5f2199609b1b8\setup.py", line 86, in
import src.future
ModuleNotFoundError: No module named 'src'
[end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

Thanks

derspanier1 · 2023-12-15T06:50:33Z

exactly the same error, also tried both methods suggested

commapython · 2023-12-15T07:27:21Z

Hi, I tried what you say but both ways (running install.bat or doing it manually) does not work.

This is the error it gives:

Collecting future (from basicsr) Using cached future-0.18.3.tar.gz (840 kB) Preparing metadata (setup.py) ... error error: subprocess-exited-with-error

× python setup.py egg_info did not run successfully. │ exit code: 1 ╰─> [6 lines of output] Traceback (most recent call last): File "", line 2, in File "", line 34, in File "C:\Users\Username\AppData\Local\Temp\pip-install-vp3ysw6c\future_27c89a6b79154a9a8ce5f2199609b1b8\setup.py", line 86, in import src.future ModuleNotFoundError: No module named 'src' [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip. error: metadata-generation-failed

Thanks

Yep, having the same issue after updating, and having tried both options to install the missing file, "basicsr".

Edit: Also tried reinstalling it through the Comfyui manager and doing it manually but got the same errors :( .

Gourieff · 2023-12-15T07:30:55Z

What version of Python do you guys have inside ComfyUI?

  python_embeded\python.exe -V

ql0wn4 · 2023-12-15T07:38:32Z

Gourieff · 2023-12-15T07:40:53Z

Download https://github.com/Gourieff/Assets/raw/main/comfyui-reactor-node/future-0.18.3-py3-none-any.whl
Put it to ComfyUI root
And run:

  python_embeded\python.exe -m pip install future-0.18.3-py3-none-any.whl

Then:

  python_embeded\python.exe -m pip install basicsr

commapython · 2023-12-15T07:49:50Z

Download https://github.com/Gourieff/Assets/raw/main/comfyui-reactor-node/future-0.18.3-py3-none-any.whl Put it to ComfyUI root And run:
  python_embeded\python.exe -m pip install future-0.18.3-py3-none-any.whl
Then:
  python_embeded\python.exe -m pip install basicsr

Genius, great work... it worked perfectly! Thanks a lot!

wutao369 · 2023-12-15T08:03:34Z

Download https://github.com/Gourieff/Assets/raw/main/comfyui-reactor-node/future-0.18.3-py3-none-any.whl下载 https://github.com/Gourieff/Assets/raw/main/comfyui-reactor-node/future-0.18.3-py3-none-any.whl Put it to ComfyUI root将其放入 ComfyUI 根目录 And run: 然后运行：
  python_embeded\python.exe -m pip install future-0.18.3-py3-none-any.whl
Then: 然后：
  python_embeded\python.exe -m pip install basicsr

Thanks a lot!

derspanier1 · 2023-12-15T08:58:40Z

Tested. Solves the problem. Good Job, Boss.

ql0wn4 · 2023-12-15T11:56:43Z

Thank you very much for your quick solution, reactor now installs properly but gives this error:

Error occurred when executing ReActorFaceSwap:

Landmark.get() takes 3 positional arguments but 4 were given

File "E:\Stable diffusion\ComfyUI\ComfyUI\execution.py", line 153, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\ComfyUI\execution.py", line 83, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\ComfyUI\execution.py", line 76, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node\nodes.py", line 112, in execute
script.process(
File "E:\Stable diffusion\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node\scripts\reactor_faceswap.py", line 96, in process
result = swap_face(
^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node\scripts\reactor_swapper.py", line 258, in swap_face
result = face_swapper.get(result, target_face, source_face)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

BigBlueGX · 2023-12-15T13:34:17Z

Thanks that works

New comfyui stand alone installation. Had the same issue as the others.

downloaded both of the following files in the root dir

https://github.com/Gourieff/Assets/raw/main/Insightface/insightface-0.7.3-cp311-cp311-win_amd64.whl
https://github.com/Gourieff/Assets/raw/main/comfyui-reactor-node/future-0.18.3-py3-none-any.whl

CMD:

python_embeded\python.exe -m pip install -U pip
python_embeded\python.exe -m pip install insightface-0.7.3-cp311-cp311-win_amd64.whl
python_embeded\python.exe -m pip install future-0.18.3-py3-none-any.whl

python_embeded\python.exe -m pip install basicsr

ran install.bat

all done

ql0wn4 · 2023-12-15T13:36:49Z

Thanks that works

New comfyui stand alone installation. Had the same issue as the others.

downloaded both of the following files in the root dir

https://github.com/Gourieff/Assets/raw/main/Insightface/insightface-0.7.3-cp311-cp311-win_amd64.whl https://github.com/Gourieff/Assets/raw/main/comfyui-reactor-node/future-0.18.3-py3-none-any.whl

CMD:

python_embeded\python.exe -m pip install -U pip python_embeded\python.exe -m pip install insightface-0.7.3-cp311-cp311-win_amd64.whl python_embeded\python.exe -m pip install future-0.18.3-py3-none-any.whl

python_embeded\python.exe -m pip install basicsr

all done

Doesn't it give the error message I have posted above?

BigBlueGX · 2023-12-15T13:45:15Z

No it worked fine for me.

It did have the following errors at first but the swapping was successful

got prompt
[ReActor] 15:38:24 - STATUS - Working: source face index [0], target face index [0]
[ReActor] 15:38:24 - STATUS - Analyzing Source Image...
2023-12-15 15:38:25.4746199 [E:onnxruntime:Default, provider_bridge_ort.cc:1480 onnxruntime::TryGetProviderInfo_CUDA] D:\a_work\1\s\onnxruntime\core\session\provider_bridge_ort.cc:1193 onnxruntime::ProviderLibrary::Get [ONNXRuntimeError] : 1 : FAIL : LoadLibrary failed with error 126 "" when trying to load "D:\SD\ComfyUI_windows_portable\python_embeded\Lib\site-packages\onnxruntime\capi\onnxruntime_providers_cuda.dll"

2023-12-15 15:39:05.0560152 [E:onnxruntime:Default, provider_bridge_ort.cc:1480 onnxruntime::TryGetProviderInfo_CUDA] D:\a_work\1\s\onnxruntime\core\session\provider_bridge_ort.cc:1193 onnxruntime::ProviderLibrary::Get [ONNXRuntimeError] : 1 : FAIL : LoadLibrary failed with error 126 "" when trying to load "D:\SD\ComfyUI_windows_portable\python_embeded\Lib\site-packages\onnxruntime\capi\onnxruntime_providers_cuda.dll"

2023-12-15 15:39:06.6173039 [E:onnxruntime:Default, provider_bridge_ort.cc:1480 onnxruntime::TryGetProviderInfo_CUDA] D:\a_work\1\s\onnxruntime\core\session\provider_bridge_ort.cc:1193 onnxruntime::ProviderLibrary::Get [ONNXRuntimeError] : 1 : FAIL : LoadLibrary failed with error 126 "" when trying to load "D:\SD\ComfyUI_windows_portable\python_embeded\Lib\site-packages\onnxruntime\capi\onnxruntime_providers_cuda.dll"

2023-12-15 15:39:06.7361794 [E:onnxruntime:Default, provider_bridge_ort.cc:1480 onnxruntime::TryGetProviderInfo_CUDA] D:\a_work\1\s\onnxruntime\core\session\provider_bridge_ort.cc:1193 onnxruntime::ProviderLibrary::Get [ONNXRuntimeError] : 1 : FAIL : LoadLibrary failed with error 126 "" when trying to load "D:\SD\ComfyUI_windows_portable\python_embeded\Lib\site-packages\onnxruntime\capi\onnxruntime_providers_cuda.dll"

2023-12-15 15:39:08.2252318 [E:onnxruntime:Default, provider_bridge_ort.cc:1480 onnxruntime::TryGetProviderInfo_CUDA] D:\a_work\1\s\onnxruntime\core\session\provider_bridge_ort.cc:1193 onnxruntime::ProviderLibrary::Get [ONNXRuntimeError] : 1 : FAIL : LoadLibrary failed with error 126 "" when trying to load "D:\SD\ComfyUI_windows_portable\python_embeded\Lib\site-packages\onnxruntime\capi\onnxruntime_providers_cuda.dll"

[ReActor] 15:39:09 - STATUS - Analyzing Target Image...
2023-12-15 15:39:23.2756571 [E:onnxruntime:Default, provider_bridge_ort.cc:1480 onnxruntime::TryGetProviderInfo_CUDA] D:\a_work\1\s\onnxruntime\core\session\provider_bridge_ort.cc:1193 onnxruntime::ProviderLibrary::Get [ONNXRuntimeError] : 1 : FAIL : LoadLibrary failed with error 126 "" when trying to load "D:\SD\ComfyUI_windows_portable\python_embeded\Lib\site-packages\onnxruntime\capi\onnxruntime_providers_cuda.dll"

[ReActor] 15:39:29 - STATUS - Swapping...
[ReActor] 15:39:30 - STATUS - --Done!--
Prompt executed in 66.16 seconds
got prompt
[ReActor] 15:41:27 - STATUS - Working: source face index [0], target face index [0]
[ReActor] 15:41:27 - STATUS - Using Hashed Source Face(s) Model...
[ReActor] 15:41:27 - STATUS - Using Hashed Target Face(s) Model...
[ReActor] 15:41:27 - STATUS - Swapping...
[ReActor] 15:41:28 - STATUS - --Done!--
Prompt executed in 0.88 seconds
got prompt
[ReActor] 15:41:40 - STATUS - Working: source face index [0], target face index [0]
[ReActor] 15:41:40 - STATUS - Using Hashed Source Face(s) Model...
[ReActor] 15:41:40 - STATUS - Using Hashed Target Face(s) Model...
[ReActor] 15:41:40 - STATUS - Swapping...
[ReActor] 15:41:40 - STATUS - --Done!--
Prompt executed in 0.81 seconds
got prompt
[ReActor] 15:41:52 - STATUS - Working: source face index [0], target face index [0]
[ReActor] 15:41:52 - STATUS - Using Hashed Source Face(s) Model...
[ReActor] 15:41:52 - STATUS - Using Hashed Target Face(s) Model...
[ReActor] 15:41:52 - STATUS - Swapping...
[ReActor] 15:41:53 - STATUS - --Done!--
Prompt executed in 0.85 seconds
got prompt
[ReActor] 15:42:04 - STATUS - Working: source face index [0], target face index [0]
[ReActor] 15:42:04 - STATUS - Using Hashed Source Face(s) Model...
[ReActor] 15:42:04 - STATUS - Using Hashed Target Face(s) Model...
[ReActor] 15:42:04 - STATUS - Swapping...
[ReActor] 15:42:04 - STATUS - --Done!--
Prompt executed in 0.84 seconds

Gourieff · 2023-12-15T13:57:58Z

Thank you very much for your quick solution, reactor now installs properly but gives this error:

Error occurred when executing ReActorFaceSwap:

Landmark.get() takes 3 positional arguments but 4 were given

File "E:\Stable diffusion\ComfyUI\ComfyUI\execution.py", line 153, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "E:\Stable diffusion\ComfyUI\ComfyUI\execution.py", line 83, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "E:\Stable diffusion\ComfyUI\ComfyUI\execution.py", line 76, in map_node_over_list results.append(getattr(obj, func)(**slice_dict(input_data_all, i))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "E:\Stable diffusion\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node\nodes.py", line 112, in execute script.process( File "E:\Stable diffusion\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node\scripts\reactor_faceswap.py", line 96, in process result = swap_face( ^^^^^^^^^^ File "E:\Stable diffusion\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node\scripts\reactor_swapper.py", line 258, in swap_face result = face_swapper.get(result, target_face, source_face) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Try to delete the Node from your workflow and add it again

ql0wn4 · 2023-12-15T14:09:39Z

Try to delete the Node from your workflow and add it again

Tried it, I also uninstalled it and reinstalled it, from manager and manually and followed your steps but it keeps giving this error:

Error occurred when executing ReActorFaceSwap:

Landmark.get() takes 3 positional arguments but 4 were given

File "E:\Stable diffusion\ComfyUI\ComfyUI\execution.py", line 153, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\ComfyUI\execution.py", line 83, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\ComfyUI\execution.py", line 76, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node\nodes.py", line 112, in execute
script.process(
File "E:\Stable diffusion\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node\scripts\reactor_faceswap.py", line 96, in process
result = swap_face(
^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node\scripts\reactor_swapper.py", line 258, in swap_face
result = face_swapper.get(result, target_face, source_face)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

and:

Obviously the previous version works just fine.

ql0wn4 · 2023-12-15T17:13:17Z

This is the error happening on a fresh install of ComfyUI while executing:

python_embeded\python.exe -m pip install future-0.18.3-py3-none-any.whl
python_embeded\python.exe -m pip install basicsr

I really don't know what else to do, I am not so knowledgeable of python, I am sorry.

Gourieff · 2023-12-15T17:39:10Z

Perhaps there's smth wrong with the inswapper model file, try to download it again https://github.com/facefusion/facefusion-assets/releases/download/models/inswapper_128.onnx and replace the existing one and make sure it's selected in the Node

ql0wn4 · 2023-12-15T18:59:47Z

I deleted and reinstalled ComfyUI, did everything from scratch, and replaced inswapper model file again and it worked for a few times ... then the error again within the same workflow:

Error occurred when executing ReActorFaceSwap:

File "E:\Stable diffusion\ComfyUI\ComfyUI\execution.py", line 153, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\ComfyUI\execution.py", line 83, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\ComfyUI\execution.py", line 76, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node\nodes.py", line 112, in execute
script.process(
File "E:\Stable diffusion\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node\scripts\reactor_faceswap.py", line 96, in process
result = swap_face(
^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node\scripts\reactor_swapper.py", line 195, in swap_face
source_faces = analyze_faces(source_img)
^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node\scripts\reactor_swapper.py", line 114, in analyze_faces
face_analyser = copy.deepcopy(getAnalysisModel())
^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node\scripts\reactor_swapper.py", line 69, in getAnalysisModel
ANALYSIS_MODEL = insightface.app.FaceAnalysis(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node\reactor_log_patch.py", line 48, in patched_faceanalysis_init
model = model_zoo.get_model(onnx_file, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\python_embeded\Lib\site-packages\insightface\model_zoo\model_zoo.py", line 96, in get_model
model = router.get_model(providers=providers, provider_options=provider_options)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node\reactor_log_patch.py", line 30, in patched_get_model
return Landmark(model_file=self.onnx_file, session=session)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\python_embeded\Lib\site-packages\insightface\model_zoo\landmark.py", line 28, in init
model = onnx.load(self.model_file)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\python_embeded\Lib\site-packages\onnx_init_.py", line 208, in load_model
model = _get_serializer(format, f).deserialize_proto(_load_bytes(f), ModelProto())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\python_embeded\Lib\site-packages\onnx\serialization.py", line 118, in deserialize_proto
decoded = typing.cast(Optional[int], proto.ParseFromString(serialized))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\python_embeded\Lib\site-packages\google\protobuf\message.py", line 202, in ParseFromString
return self.MergeFromString(serialized)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\python_embeded\Lib\site-packages\google\protobuf\internal\python_message.py", line 1128, in MergeFromString
if self._InternalParse(serialized, 0, length) != length:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\python_embeded\Lib\site-packages\google\protobuf\internal\python_message.py", line 1195, in InternalParse
pos = field_decoder(buffer, new_pos, end, self, field_dict)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\python_embeded\Lib\site-packages\google\protobuf\internal\decoder.py", line 726, in DecodeField
if value._InternalParse(buffer, pos, new_pos) != new_pos:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\python_embeded\Lib\site-packages\google\protobuf\internal\python_message.py", line 1195, in InternalParse
pos = field_decoder(buffer, new_pos, end, self, field_dict)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\python_embeded\Lib\site-packages\google\protobuf\internal\decoder.py", line 705, in DecodeRepeatedField
if value.add()._InternalParse(buffer, pos, new_pos) != new_pos:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\python_embeded\Lib\site-packages\google\protobuf\internal\python_message.py", line 1195, in InternalParse
pos = field_decoder(buffer, new_pos, end, self, field_dict)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "E:\Stable diffusion\ComfyUI\python_embeded\Lib\site-packages\google\protobuf\internal\decoder.py", line 208, in DecodePackedField
value.append(element)
File "E:\Stable diffusion\ComfyUI\python_embeded\Lib\site-packages\google\protobuf\internal\containers.py", line 150, in append
self._values.append(self._type_checker.CheckValue(value))

corvo4791 · 2023-12-15T21:50:35Z

Download https://github.com/Gourieff/Assets/raw/main/comfyui-reactor-node/future-0.18.3-py3-none-any.whl下载 https://github.com/Gourieff/Assets/raw/main/comfyui-reactor-node/future-0.18.3-py3-none-any.whl Put it to ComfyUI root将其放入 ComfyUI 根目录 And run: 然后运行：
  python_embeded\python.exe -m pip install future-0.18.3-py3-none-any.whl
Then: 然后：
  python_embeded\python.exe -m pip install basicsr
Thanks a lot!

Hello, everyone.
I solved thanks

Issues: #136 #141 #142

ql0wn4 · 2023-12-18T07:58:29Z

I deleted and reinstalled ComfyUI, did everything from scratch, and replaced inswapper model file again and it worked for a few times ... then the error again within the same workflow:

It's working now.

gabrie · 2023-12-19T05:52:46Z

I did "pip install future-0.18.3-py3-none-any.whl", which was successful.

Then I ran pip install basicsr, which led to below error.

I'm on M2 Mac.
Weird thing is, previously I did nothing, and it could be loaded, then yesterday I found it's [Fail to load], then I tried to follow above steps.

error: subprocess-exited-with-error

× pip subprocess to install backend dependencies did not run successfully.
│ exit code: 1
╰─> [4 lines of output]
Collecting cython
Using cached Cython-3.0.6-py2.py3-none-any.whl.metadata (3.2 kB)
ERROR: Could not find a version that satisfies the requirement torch (from versions: none)
ERROR: No matching distribution found for torch
[end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× pip subprocess to install backend dependencies did not run successfully.
│ exit code: 1
╰─> See above for output.

Gourieff · 2023-12-19T08:25:44Z

@gabrie try this #141 (comment)

gabrie · 2023-12-19T10:37:18Z

@gabrie try this #141 (comment)

Thanks, tried, successfully installed, but still fail to load.

Theshadows007 · 2023-12-20T02:48:01Z

Yes, ComfyUI doesn't have "basicsr" lib by default - but without this lib CodeFormer doesn't have all its functionality To install this package you should run install.bat (inside ReActor's folder) or do it manually from ComfyUI root:：
  python_embeded\python.exe -m pip install basicsr

Referenced but error Preparing metadata (setup.py) ... error
error: subprocess-exited-with-error

× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [18 lines of output]
Traceback (most recent call last):
File "C:\Users\user！\AppData\Local\Temp\pip-install-l49unwwf\basicsr_6db14827a33d4eb2b694b25f4fc14adb\setup.py", line 50, in get_hash
from basicsr.version import version
ModuleNotFoundError: No module named 'basicsr'

  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "<string>", line 2, in <module>
    File "<pip-setuptools-caller>", line 34, in <module>
    File "C:\Users\user！\AppData\Local\Temp\pip-install-l49unwwf\basicsr_6db14827a33d4eb2b694b25f4fc14adb\setup.py", line 139, in <module>
      write_version_py()
    File "C:\Users\user！\AppData\Local\Temp\pip-install-l49unwwf\basicsr_6db14827a33d4eb2b694b25f4fc14adb\setup.py", line 67, in write_version_py
      sha = get_hash()
            ^^^^^^^^^^
    File "C:\Users\user！\AppData\Local\Temp\pip-install-l49unwwf\basicsr_6db14827a33d4eb2b694b25f4fc14adb\setup.py", line 53, in get_hash
      raise ImportError('Unable to get git version')
  ImportError: Unable to get git version
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Theshadows007 · 2023-12-20T02:49:29Z

I did "pip install future-0.18.3-py3-none-any.whl", which was successful.

Then I ran pip install basicsr, which led to below error.

I'm on M2 Mac. Weird thing is, previously I did nothing, and it could be loaded, then yesterday I found it's [Fail to load], then I tried to follow above steps.

error: subprocess-exited-with-error

× pip subprocess to install backend dependencies did not run successfully. │ exit code: 1 ╰─> [4 lines of output] Collecting cython Using cached Cython-3.0.6-py2.py3-none-any.whl.metadata (3.2 kB) ERROR: Could not find a version that satisfies the requirement torch (from versions: none) ERROR: No matching distribution found for torch [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip. error: subprocess-exited-with-error

× pip subprocess to install backend dependencies did not run successfully. │ exit code: 1 ╰─> See above for output.

I'm also having such an issue

Due to a lot of issues caused by installation failures of bacisr (->future lib error) in Py311 enclosures #136 #141 #152 #154

Gourieff · 2023-12-22T18:52:07Z

Please update guys
BasicSR is built-in now (inside the ReActor's Node folder)

Emirufio · 2024-01-10T10:31:32Z

I tried to do what you said
Nothing works for me
I still have the same issue when i load the workflow
"When loading the graph, the following node types were not found:
FaceRestoreWithModel
ReActorFaceSwap
Nodes that have failed to load will show as red on the graph."

johndpope · 2024-01-22T00:52:57Z

The faceRestoreWithModel module - use this - https://github.com/mav-rik/facerestore_cf

with the other error - I am in same boat -
the repo exists - https://github.com/Gourieff/comfyui-reactor-node.git

when comfyui boots up i get this error
with ReactorFaceSwap

### Loading: ComfyUI-Inspire-Pack (V0.60)
Traceback (most recent call last):
  File "/media/2TB/ComfyUI/nodes.py", line 1872, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/media/2TB/ComfyUI/custom_nodes/comfyui-reactor-node/__init__.py", line 25, in <module>
    from .nodes import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
  File "/media/2TB/ComfyUI/custom_nodes/comfyui-reactor-node/nodes.py", line 14, in <module>
    from scripts.reactor_faceswap import FaceSwapScript, get_models, get_current_faces_model, analyze_faces
ModuleNotFoundError: No module named 'scripts.reactor_faceswap'

UPDATE

chatgpt - saves the day
https://chat.openai.com/share/c6e966c9-9573-459b-bd3a-6ba09c45ed2f

this project needs a (an empty) file in the scripts folder init.py
add

now it boots up.

I create a PR

UPDATE
now seeing this

can't work it out -

adding these - helps
CodeFormer: https://github.com/sczhou/CodeFormer/releases/download/v0.1.0/codeformer.pth
GFPGAN: https://github.com/TencentARC/GFPGAN/releases/download/v1.3.4/GFPGANv1.4.pth

ComfyUI\custom_nodes\comfyui-reactor-node\models\facerestore_models directory

UPDATE -
ok - selecting from list resolves issue.

f-rank added bug Something isn't working new labels Dec 14, 2023

f-rank changed the title ~~after install, it can't seem to install dependency~~ after update, it can't seem to install dependency Dec 14, 2023

Gourieff removed bug Something isn't working new labels Dec 15, 2023

Gourieff changed the title ~~after update, it can't seem to install dependency~~ [IMPORTANT TO DO] ModuleNotFoundError: No module named 'basicsr' Dec 15, 2023

Gourieff pinned this issue Dec 15, 2023

Gourieff added a commit that referenced this issue Dec 15, 2023

UPDATE: "No module basicsr" error instruction

14e6f77

Issue #136

Gourieff added the 🔥 HOT label Dec 15, 2023

Gourieff added the ✔ solved label Dec 15, 2023

Gourieff changed the title ~~[IMPORTANT TO DO] ModuleNotFoundError: No module named 'basicsr'~~ [SOLVED] ModuleNotFoundError: No module named 'basicsr' Dec 15, 2023

This was referenced Dec 16, 2023

installation failed #141

Closed

Won't install after latest update #142

Closed

Gourieff added a commit that referenced this issue Dec 16, 2023

FIX: "Future" Lib + Py311 installation conflict

8d8b56a

Issues: #136 #141 #142

Gourieff added a commit that referenced this issue Dec 22, 2023

UPDATE+FIX: BasicSR lib built-in

f0e7fd7

Due to a lot of issues caused by installation failures of bacisr (->future lib error) in Py311 enclosures #136 #141 #152 #154

Gourieff added the ✔ fixed label Dec 22, 2023

johndpope mentioned this issue Jan 22, 2024

comfybox - simpler workflow fails to load space-nuko/ComfyBox#159

Open

Gourieff closed this as completed Feb 1, 2024

Gourieff unpinned this issue Feb 24, 2024

Sharknaab mentioned this issue Aug 28, 2024

ComfyUI ReActor node import failed : [ERROR] Failed to execute install/(de)activation script AND pydantic_core issue #407

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SOLVED] ModuleNotFoundError: No module named 'basicsr' #136

[SOLVED] ModuleNotFoundError: No module named 'basicsr' #136

f-rank commented Dec 14, 2023

wutao369 commented Dec 15, 2023

Gourieff commented Dec 15, 2023

Gourieff commented Dec 15, 2023

ql0wn4 commented Dec 15, 2023

derspanier1 commented Dec 15, 2023

commapython commented Dec 15, 2023 •

edited

Loading

Gourieff commented Dec 15, 2023

ql0wn4 commented Dec 15, 2023

Gourieff commented Dec 15, 2023

commapython commented Dec 15, 2023

wutao369 commented Dec 15, 2023

derspanier1 commented Dec 15, 2023

ql0wn4 commented Dec 15, 2023

BigBlueGX commented Dec 15, 2023 •

edited

Loading

ql0wn4 commented Dec 15, 2023

BigBlueGX commented Dec 15, 2023

Gourieff commented Dec 15, 2023

ql0wn4 commented Dec 15, 2023 •

edited

Loading

ql0wn4 commented Dec 15, 2023 •

edited

Loading

Gourieff commented Dec 15, 2023 •

edited

Loading

ql0wn4 commented Dec 15, 2023

corvo4791 commented Dec 15, 2023 •

edited

Loading

ql0wn4 commented Dec 18, 2023

gabrie commented Dec 19, 2023

Gourieff commented Dec 19, 2023

gabrie commented Dec 19, 2023

Theshadows007 commented Dec 20, 2023

Theshadows007 commented Dec 20, 2023

Gourieff commented Dec 22, 2023

Emirufio commented Jan 10, 2024

johndpope commented Jan 22, 2024 •

edited

Loading

[SOLVED] ModuleNotFoundError: No module named 'basicsr' #136

[SOLVED] ModuleNotFoundError: No module named 'basicsr' #136

Comments

f-rank commented Dec 14, 2023

First, confirm

What happened?

Steps to reproduce the problem

Sysinfo

Relevant console log

Additional information

wutao369 commented Dec 15, 2023

Gourieff commented Dec 15, 2023

Gourieff commented Dec 15, 2023

ql0wn4 commented Dec 15, 2023

derspanier1 commented Dec 15, 2023

commapython commented Dec 15, 2023 • edited Loading

Gourieff commented Dec 15, 2023

ql0wn4 commented Dec 15, 2023

Gourieff commented Dec 15, 2023

commapython commented Dec 15, 2023

wutao369 commented Dec 15, 2023

derspanier1 commented Dec 15, 2023

ql0wn4 commented Dec 15, 2023

BigBlueGX commented Dec 15, 2023 • edited Loading

ql0wn4 commented Dec 15, 2023

BigBlueGX commented Dec 15, 2023

Gourieff commented Dec 15, 2023

ql0wn4 commented Dec 15, 2023 • edited Loading

ql0wn4 commented Dec 15, 2023 • edited Loading

Gourieff commented Dec 15, 2023 • edited Loading

ql0wn4 commented Dec 15, 2023

corvo4791 commented Dec 15, 2023 • edited Loading

ql0wn4 commented Dec 18, 2023

gabrie commented Dec 19, 2023

Gourieff commented Dec 19, 2023

gabrie commented Dec 19, 2023

Theshadows007 commented Dec 20, 2023

Theshadows007 commented Dec 20, 2023

Gourieff commented Dec 22, 2023

Emirufio commented Jan 10, 2024

johndpope commented Jan 22, 2024 • edited Loading

commapython commented Dec 15, 2023 •

edited

Loading

BigBlueGX commented Dec 15, 2023 •

edited

Loading

ql0wn4 commented Dec 15, 2023 •

edited

Loading

ql0wn4 commented Dec 15, 2023 •

edited

Loading

Gourieff commented Dec 15, 2023 •

edited

Loading

corvo4791 commented Dec 15, 2023 •

edited

Loading

johndpope commented Jan 22, 2024 •

edited

Loading