Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

chore(dep): Update google/go-container-registry to support OCI #390

Closed
wants to merge 1 commit into from
Closed

Conversation

BronzeDeer
Copy link

Fixes #389

container-diff currently uses an ancient pre-v0.1.0 commit of google/go-containerregistry to handle interactions with container registries, which leads to problems in modern contexts, for example when OCI indexes or images are encountered

This commit bumps google/go-containerregistry to the newest release (v0.13.0)

container-diff currently uses an ancient pre-v0.1.0 commit of
google/go-containerregistry to handle interactions with container
registries, which leads to problems in modern contexts, for example when
OCI indexes or images are encountered

This commit bumps google/go-containerregistry to the newest release
(v0.13.0)
@BronzeDeer
Copy link
Author

@maintainers, would it be possible to get some eyes on this? This fix is holding up multiple fixes in kaniko

@TBG-FR
Copy link

TBG-FR commented Mar 22, 2023

+1 🚀

However i don't know if @maintainers tag is working, so... @nkubala @tequilarista @tstromberg can you have a look ?

This fixes an issue which is currently breaking some pipelines 😬

@TBG-FR
Copy link

TBG-FR commented Apr 27, 2023

Sorry to bother you again guys, but this issue is really blocking important (re)builds... @nkubala @tequilarista @tstromberg 🙏

If you're lacking interest or time for this project, we can probably find a way to keep it active without bothering you... Looks like a lot of contributions are waiting approval/action ! 🧑‍🤝‍🧑

@loosebazooka
Copy link
Member

I think this update has occurred

@BronzeDeer
Copy link
Author

Fixed by d8d566b. Closing

@BronzeDeer BronzeDeer closed this Feb 21, 2024
@BronzeDeer BronzeDeer deleted the bump-ggcr branch February 21, 2024 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container-diff cannot download images with OCI manifest
3 participants